From: Theodore Ts'o <tytso@mit.edu>
To: "Dilger, Andreas" <andreas.dilger@intel.com>
Cc: "Zhang, Hongchao" <hongchao.zhang@intel.com>,
Eric Sandeen <sandeen@redhat.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: an issue of ext4
Date: Thu, 6 Mar 2014 20:52:55 -0500 [thread overview]
Message-ID: <20140307015255.GA12443@thunk.org> (raw)
In-Reply-To: <CF3CDE77.96870%andreas.dilger@intel.com>
On Thu, Mar 06, 2014 at 11:57:15PM +0000, Dilger, Andreas wrote:
> However, looking more closely at the upstream kernel, I see that this
> code was changed by Dmitry Monakhov in v2.6.34-rc7-16-g84061e0 to
> move the counters after journal init (almost the same as Hongchao's
> patch does) but then you submitted a patch v2.6.37-rc1-3-gce7e010
> to initialize the percpu counters are both before and after the
> journal is loaded. It isn't clear from your commit comment why
> the patch to load them both before and after was needed?
I can't remembe the code path that was referencing one or more of the
percpu counters, it must have been some non-common corner case, since
we didn't notice the issue right away, but I believe that's why the
change was made. My bad for not including more details in the commit
description....
- Ted
prev parent reply other threads:[~2014-03-07 1:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 12:33 an issue of ext4 Zhang, Hongchao
2014-03-05 12:51 ` Theodore Ts'o
2014-03-06 23:57 ` Dilger, Andreas
2014-03-07 1:52 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307015255.GA12443@thunk.org \
--to=tytso@mit.edu \
--cc=andreas.dilger@intel.com \
--cc=hongchao.zhang@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.