Re: [PATCH V2] i2c: mv64xxx: fix circular Kconfig dependency

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

Hi Wolfram,

On Thu, Mar 06, 2014 at 09:32:55PM +0100, Wolfram Sang wrote:
> Commit 370136bc67c3 ("i2c: mv64xxx: Add reset deassert call")
> introduced:
> 
> drivers/video/Kconfig:42:error: recursive dependency detected!
> 
> ARCH_SUNXI selects RESET_CONTROLLER anyhow.
> 
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> ---
>  drivers/i2c/busses/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 70bcad941657..f8162441576f 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -527,8 +527,7 @@ config I2C_MPC
>  
>  config I2C_MV64XXX
>  	tristate "Marvell mv64xxx I2C Controller"
> -	depends on (MV64X60 || PLAT_ORION || ARCH_SUNXI)
> -	select RESET_CONTROLLER
> +	depends on MV64X60 || PLAT_ORION || ARCH_SUNXI

I'm not sure it actually works.

MV64X60 and PLAT_ORION don't select RESET_CONTROLLER, and the
functions won't be declared, resulting in a compilation breakage too.

Maybe we can just depend on RESET_CONTROLLER too here, to fix the
circular dependency.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]