From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [RFC, PATCH] xfs: make superblock version checks reflect reality
Date: Fri, 7 Mar 2014 02:16:37 -0800 [thread overview]
Message-ID: <20140307101637.GD32333@infradead.org> (raw)
In-Reply-To: <20140307083430.GQ6851@dastard>
On Fri, Mar 07, 2014 at 07:34:30PM +1100, Dave Chinner wrote:
> Ok, we don't reject filesystems that don't have the NLINK bit set.
> Older filesystems that have only v1 inodes won't have that bit
> set, and we didn't set NLINK by default in mkfs until late 2007.
> Hence we need to keep some form of NLINK support around.
>
> The alternative is to simply set the bit in the superblock if it is
> not set, and then just assume everywhere that it is set and we are
> using v2 inodes. That will get rid of the hasnlink/addnlink code
> needed to modify the superblock when the link count goes above
> MAX_NLINK_1, and will result in filesystems always converting v1
> inodes to v2 inodes on writeback of dirty inodes. I don't see a
> problem with taking this approach, bt maybe I'm missing something?
I'd love to get rid of v1 support sprinkled all over. Obviously this
should be a separate patch, but making both the code and the in-use
filesystems less diverse is a good idea.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-07 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 6:54 [RFC, PATCH] xfs: make superblock version checks reflect reality Dave Chinner
2014-03-06 18:05 ` Christoph Hellwig
2014-03-06 22:55 ` Dave Chinner
2014-03-07 8:34 ` Dave Chinner
2014-03-07 10:16 ` Christoph Hellwig [this message]
2014-03-07 10:15 ` Christoph Hellwig
2014-03-09 0:32 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307101637.GD32333@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.