All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] net: asix: don't pad odd-length TX packets
Date: Sat, 8 Mar 2014 12:32:13 +0100	[thread overview]
Message-ID: <201403081232.13919.marex@denx.de> (raw)
In-Reply-To: <20140307222737.GH16805@bill-the-cat>

On Friday, March 07, 2014 at 11:27:37 PM, Tom Rini wrote:
> On Thu, Feb 27, 2014 at 01:27:02PM -0700, Stephen Warren wrote:
> > From: Stephen Warren <swarren@nvidia.com>
> > 
> > For Ethernet/USB RX packets, the ASIX HW pads odd-sized packets so that
> > they have an even size. Currently, asix_recv() does remove this padding,
> > and asic_send() adds equivalent padding in the TX path. However, the HW
> > does not appear to need this packing for TX packets in practical testing
> > with "ASIX Elec. Corp. AX88x72A 000001" Vendor: 0x0b95 Product 0x7720
> > Version 0.1. The Linux kernel does no such padding for the TX path.
> > 
> > Remove the padding from the TX path:
> > 
> > * For consistency with the Linux kernel.
> > * NVIDIA has a Tegra simulator which validates that the length of USB
> > 
> >   packets sent to an ASIX device matches the packet length value inside
> >   the packet data. Having U-Boot and the kernel do the same thing when
> >   creating the TX packets simplifies the simulator's validation.
> > 
> > Cc: Lucas Stach <dev@lynxeye.de>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Simon Glass <sjg@chromium.org>
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > Acked-by: Simon Glass <sjg@chromium.org>
> > Acked-by: Marek Vasut <marex@denx.de>
> > Tested-by: Marek Vasut <marex@denx.de>
> > Tested-by: Gerhard Sittig <gsi@denx.de>
> 
> Applied to u-boot/master, thanks!

Uh, where did Joe disappear to anyway ?

Best regards,
Marek Vasut

  reply	other threads:[~2014-03-08 11:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 20:27 [U-Boot] [PATCH] net: asix: don't pad odd-length TX packets Stephen Warren
2014-02-27 20:38 ` Simon Glass
2014-02-28 10:54   ` Marek Vasut
2014-03-03 14:14     ` Gerhard Sittig
2014-03-03 14:24       ` Marek Vasut
2014-03-07 22:27 ` [U-Boot] " Tom Rini
2014-03-08 11:32   ` Marek Vasut [this message]
2014-03-10 22:11     ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201403081232.13919.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.