All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: shmobile: Add temporary include workaround
Date: Sun, 09 Mar 2014 05:35:08 +0000	[thread overview]
Message-ID: <20140309053508.GC12854@quad.lixom.net> (raw)
In-Reply-To: <20140224224446.14786.79602.sendpatchset@w520>

On Tue, Feb 25, 2014 at 07:44:46AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add temporary include path in the mach-shmobile Makefile to
> aid coversion from using <mach/something.h> to "something.h"
> in the source files.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> 
> ---
> 
>  Changes since V1:
>  - Use += instead of := to avoid breaking MULTIPLATFORM
> 
>  arch/arm/mach-shmobile/Makefile |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- 0001/arch/arm/mach-shmobile/Makefile
> +++ work/arch/arm/mach-shmobile/Makefile	2014-02-25 07:41:56.000000000 +0900
> @@ -4,6 +4,8 @@
>  
>  ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/arch/arm/mach-shmobile/include
>  
> +ccflags-y += -I$(srctree)/arch/arm/mach-shmobile/include/mach
> +
>  # Common objects
>  obj-y				:= timer.o console.o
>  

Hmm. Not a fan of doing this. Let's just do the include file move with
the include string changes instead on each instance.

WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: shmobile: Add temporary include workaround
Date: Sat, 8 Mar 2014 21:35:08 -0800	[thread overview]
Message-ID: <20140309053508.GC12854@quad.lixom.net> (raw)
In-Reply-To: <20140224224446.14786.79602.sendpatchset@w520>

On Tue, Feb 25, 2014 at 07:44:46AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add temporary include path in the mach-shmobile Makefile to
> aid coversion from using <mach/something.h> to "something.h"
> in the source files.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> 
> ---
> 
>  Changes since V1:
>  - Use += instead of := to avoid breaking MULTIPLATFORM
> 
>  arch/arm/mach-shmobile/Makefile |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- 0001/arch/arm/mach-shmobile/Makefile
> +++ work/arch/arm/mach-shmobile/Makefile	2014-02-25 07:41:56.000000000 +0900
> @@ -4,6 +4,8 @@
>  
>  ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/arch/arm/mach-shmobile/include
>  
> +ccflags-y += -I$(srctree)/arch/arm/mach-shmobile/include/mach
> +
>  # Common objects
>  obj-y				:= timer.o console.o
>  

Hmm. Not a fan of doing this. Let's just do the include file move with
the include string changes instead on each instance.

  reply	other threads:[~2014-03-09  5:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 22:44 [PATCH v2] ARM: shmobile: Add temporary include workaround Magnus Damm
2014-02-24 22:44 ` Magnus Damm
2014-03-09  5:35 ` Olof Johansson [this message]
2014-03-09  5:35   ` Olof Johansson
2014-03-10  1:56   ` Magnus Damm
2014-03-10  1:56     ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140309053508.GC12854@quad.lixom.net \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.