From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Date: Sat, 8 Mar 2014 21:39:24 -0800 Subject: [PATCH 1/4] ARM: dts: keystone: update for supporting K2L/K2E EVMs In-Reply-To: <1393365035-20083-2-git-send-email-santosh.shilimkar@ti.com> References: <1393365035-20083-1-git-send-email-santosh.shilimkar@ti.com> <1393365035-20083-2-git-send-email-santosh.shilimkar@ti.com> Message-ID: <20140309053924.GD12854@quad.lixom.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 25, 2014 at 04:50:32PM -0500, Santosh Shilimkar wrote: > From: Murali Karicheri > > This patch add compatibility strings for k2hk, k2l and k2e EVMs > > Cc: Olof Johansson > Cc: Arnd Bergmann > Cc: Rob Herring > Cc: Kumar Gala > Cc: Mark Rutland > Signed-off-by: Murali Karicheri > Signed-off-by: Santosh Shilimkar > --- > .../devicetree/bindings/arm/keystone/keystone.txt | 10 ++++++++++ > arch/arm/mach-keystone/keystone.c | 3 +++ > 2 files changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/keystone/keystone.txt b/Documentation/devicetree/bindings/arm/keystone/keystone.txt > index 63c0e6a..ad16e7a 100644 > --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt > +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt > @@ -8,3 +8,13 @@ Required properties: > - compatible: All TI specific devices present in Keystone SOC should be in > the form "ti,keystone-*". Generic devices like gic, arch_timers, ns16550 > type UART should use the specified compatible for those devices. > + > +Boards: > +- Keystone 2 Hawking/Kepler EVM > + compatible = "ti,k2hk-evm" > + > +- Keystone 2 Lamarr EVM > + compatible = "ti,k2l-evm" Your previous email said Lammar. One, or maybe both, are wrong, but which one? > + > +- Keystone 2 Edison EVM > + compatible = "ti,k2e-evm" > diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c > index 6e6bb7d..aa0d212 100644 > --- a/arch/arm/mach-keystone/keystone.c > +++ b/arch/arm/mach-keystone/keystone.c > @@ -47,6 +47,9 @@ static void __init keystone_init(void) > > static const char *keystone_match[] __initconst = { > "ti,keystone-evm", > + "ti,k2hk-evm", > + "ti,k2l-evm", > + "ti,k2e-evm", -evm indicate board-level compat fields. We'd be better off just keeping a "ti,keystone" top-level compatible here and just using that to probe. That way you don't have to touch the file for new boards in the future. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 1/4] ARM: dts: keystone: update for supporting K2L/K2E EVMs Date: Sat, 8 Mar 2014 21:39:24 -0800 Message-ID: <20140309053924.GD12854@quad.lixom.net> References: <1393365035-20083-1-git-send-email-santosh.shilimkar@ti.com> <1393365035-20083-2-git-send-email-santosh.shilimkar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1393365035-20083-2-git-send-email-santosh.shilimkar-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Santosh Shilimkar Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Murali Karicheri , Arnd Bergmann , Rob Herring , Kumar Gala , Mark Rutland List-Id: devicetree@vger.kernel.org On Tue, Feb 25, 2014 at 04:50:32PM -0500, Santosh Shilimkar wrote: > From: Murali Karicheri > > This patch add compatibility strings for k2hk, k2l and k2e EVMs > > Cc: Olof Johansson > Cc: Arnd Bergmann > Cc: Rob Herring > Cc: Kumar Gala > Cc: Mark Rutland > Signed-off-by: Murali Karicheri > Signed-off-by: Santosh Shilimkar > --- > .../devicetree/bindings/arm/keystone/keystone.txt | 10 ++++++++++ > arch/arm/mach-keystone/keystone.c | 3 +++ > 2 files changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/keystone/keystone.txt b/Documentation/devicetree/bindings/arm/keystone/keystone.txt > index 63c0e6a..ad16e7a 100644 > --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt > +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt > @@ -8,3 +8,13 @@ Required properties: > - compatible: All TI specific devices present in Keystone SOC should be in > the form "ti,keystone-*". Generic devices like gic, arch_timers, ns16550 > type UART should use the specified compatible for those devices. > + > +Boards: > +- Keystone 2 Hawking/Kepler EVM > + compatible = "ti,k2hk-evm" > + > +- Keystone 2 Lamarr EVM > + compatible = "ti,k2l-evm" Your previous email said Lammar. One, or maybe both, are wrong, but which one? > + > +- Keystone 2 Edison EVM > + compatible = "ti,k2e-evm" > diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c > index 6e6bb7d..aa0d212 100644 > --- a/arch/arm/mach-keystone/keystone.c > +++ b/arch/arm/mach-keystone/keystone.c > @@ -47,6 +47,9 @@ static void __init keystone_init(void) > > static const char *keystone_match[] __initconst = { > "ti,keystone-evm", > + "ti,k2hk-evm", > + "ti,k2l-evm", > + "ti,k2e-evm", -evm indicate board-level compat fields. We'd be better off just keeping a "ti,keystone" top-level compatible here and just using that to probe. That way you don't have to touch the file for new boards in the future. -Olof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html