All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Harald Albrecht <harald.albrecht@gmx.net>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: drivers/input/input.c and a broken USB HID Contour ShuttlePRO v2
Date: Sun, 9 Mar 2014 10:19:07 -0700	[thread overview]
Message-ID: <20140309171907.GC30196@kroah.com> (raw)
In-Reply-To: <531C8EF4.9090609@gmx.net>

On Sun, Mar 09, 2014 at 04:55:32PM +0100, Harald Albrecht wrote:
> I would like to improve support for the multimedia controllers from 
> Contour company, as there currently get relative events swalled by input.c.
> 
> The background: Contour seems to have messed up the USB HID descriptions 
> of their multimedia controller devices in that these report to use 
> relative axis when in fact they are creating EV_REL events with absolute 
> coordinate values. The problem here is, that mapping these events to 
> EV_ABS will break all existing software that supports these devices.
> 
> Unfortunately, drivers/input/input.c correctly swallows any relative 
> events with a relative movement value of zero...
> 
>     case EV_REL:
>        if (is_event_supported(code, dev->relbit, REL_MAX) && value)
>          disposition = INPUT_PASS_TO_HANDLERS;
>        break;
> 
> Simply removing the "&& value" would most probably have adverse effect 
> on many software. Unfortunately, there is yet no "quirks" handling 
> present in input.c.
> 
> How can I add such quirks handling in a way that would be acceptable by 
> the kernel maintainers?

The people on linux-input@vger.kernel.org (now cc:ed) might know more...

       reply	other threads:[~2014-03-09 17:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <531C8EF4.9090609@gmx.net>
2014-03-09 17:19 ` Greg KH [this message]
2014-03-09 17:31   ` drivers/input/input.c and a broken USB HID Contour ShuttlePRO v2 Harald Albrecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140309171907.GC30196@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=harald.albrecht@gmx.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.