From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 5/6] pkg-cmake.mk: add PATH in the configure command environment
Date: Mon, 10 Mar 2014 00:18:05 +0100 [thread overview]
Message-ID: <20140309231805.GF3194@free.fr> (raw)
In-Reply-To: <1394373623-10650-6-git-send-email-s.martin49@gmail.com>
Samuel, All,
On 2014-03-09 15:00 +0100, Samuel Martin spake thusly:
> Because BR_PATH is not exported in the environment beforehand running
> cmake, it is necessary to add it on the cmake configure command.
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> changes v4 -> v6:
> - rebase
>
> changes v3 -> v4:
> - rebase
> - rename BR2_PATH -> BR_PATH
>
> changes v2 -> v3:
> - rebase
> - no one-line commit log (ThomasP)
>
> changes v1 -> v2:
> - remove explicit PATH=... in configure commands in pkg-autotools.mk
> because it is already added via *_CONFIGURE_OPTS (ThomasP), and
> reword the commit message.
> ---
> package/pkg-cmake.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> index f7e454b..bf3db90 100644
> --- a/package/pkg-cmake.mk
> +++ b/package/pkg-cmake.mk
> @@ -60,6 +60,7 @@ ifeq ($(4),target)
> define $(2)_CONFIGURE_CMDS
> (cd $$($$(PKG)_BUILDDIR) && \
> rm -f CMakeCache.txt && \
> + PATH=$(BR_PATH) \
> $$($$(PKG)_CONF_ENV) $(HOST_DIR)/usr/bin/cmake $$($$(PKG)_SRCDIR) \
> -DCMAKE_TOOLCHAIN_FILE="$$(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake" \
> -DCMAKE_INSTALL_PREFIX="/usr" \
> @@ -74,6 +75,7 @@ else
> define $(2)_CONFIGURE_CMDS
> (cd $$($$(PKG)_BUILDDIR) && \
> rm -f CMakeCache.txt && \
> + PATH=$(BR_PATH) \
> $(HOST_DIR)/usr/bin/cmake $$($$(PKG)_SRCDIR) \
> -DCMAKE_INSTALL_SO_NO_EXE=0 \
> -DCMAKE_FIND_ROOT_PATH="$$(HOST_DIR)" \
> --
> 1.9.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-03-09 23:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 14:00 [Buildroot] [PATCH v6 0/6] PATH cleanup Samuel Martin
2014-03-09 14:00 ` [Buildroot] [PATCH v6 1/6] Makefile: introduce BR_PATH Samuel Martin
2014-03-09 22:57 ` Yann E. MORIN
2014-03-09 14:00 ` [Buildroot] [PATCH v6 2/6] Makefile: add $(HOST_DIR)/sbin to BR_PATH Samuel Martin
2014-03-09 22:58 ` Yann E. MORIN
2014-03-09 14:00 ` [Buildroot] [PATCH v6 3/6] *.mk: replace (TARGET|HOST)_PATH by BR_PATH Samuel Martin
2014-03-09 23:05 ` Yann E. MORIN
2014-03-09 23:24 ` Yann E. MORIN
2014-03-09 14:00 ` [Buildroot] [PATCH v6 4/6] infra: remove unused {TARGET, HOST}_PATH definition Samuel Martin
2014-03-09 23:05 ` Yann E. MORIN
2014-03-09 14:00 ` [Buildroot] [PATCH v6 5/6] pkg-cmake.mk: add PATH in the configure command environment Samuel Martin
2014-03-09 23:18 ` Yann E. MORIN [this message]
2014-03-09 14:00 ` [Buildroot] [PATCH v6 6/6] Makefile: add PATH to the USER_HOOKS_EXTRA_ENV Samuel Martin
2014-03-09 23:19 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140309231805.GF3194@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.