From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/5] ARM: STi: DT: add keyscan for stih415 Date: Mon, 10 Mar 2014 11:50:21 +0000 Message-ID: <20140310115021.GP14976@lee--X1> References: <1393990772-9567-1-git-send-email-gabriel.fernandez@st.com> <1393990772-9567-3-git-send-email-gabriel.fernandez@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-we0-f175.google.com ([74.125.82.175]:60493 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753162AbaCJLu2 (ORCPT ); Mon, 10 Mar 2014 07:50:28 -0400 Received: by mail-we0-f175.google.com with SMTP id q58so8407590wes.34 for ; Mon, 10 Mar 2014 04:50:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1393990772-9567-3-git-send-email-gabriel.fernandez@st.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Gabriel FERNANDEZ Cc: Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Russell King , Grant Likely , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, kernel@stlinux.com, Giuseppe CONDORELLI > From: Giuseppe CONDORELLI >=20 > Add keyscan support for stih415. > It is put disabled by default because it is not enabled on all boards > Also there are PIOs conflict with already claimed lines. >=20 > Signed-off-by: Giuseppe Condorelli > Signed-off-by: Gabriel Fernandez > --- > arch/arm/boot/dts/stih415-pinctrl.dtsi | 16 ++++++++++++++++ > arch/arm/boot/dts/stih415.dtsi | 10 ++++++++++ > 2 files changed, 26 insertions(+) > + keyscan: keyscan@fe4b0000 { > + compatible =3D "st,keypad"; > + status =3D "disabled"; > + reg =3D <0xfe4b0000 0x2000>; > + interrupts =3D ; > + clocks =3D <&CLK_SYSIN>; > + pinctrl-names =3D "default"; Small nit here, but otherwise: Acked-by: Lee Jones > + pinctrl-0 =3D <&pinctrl_keyscan>; > + }; > }; > }; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 10 Mar 2014 11:50:21 +0000 Subject: [PATCH 2/5] ARM: STi: DT: add keyscan for stih415 In-Reply-To: <1393990772-9567-3-git-send-email-gabriel.fernandez@st.com> References: <1393990772-9567-1-git-send-email-gabriel.fernandez@st.com> <1393990772-9567-3-git-send-email-gabriel.fernandez@st.com> Message-ID: <20140310115021.GP14976@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > From: Giuseppe CONDORELLI > > Add keyscan support for stih415. > It is put disabled by default because it is not enabled on all boards > Also there are PIOs conflict with already claimed lines. > > Signed-off-by: Giuseppe Condorelli > Signed-off-by: Gabriel Fernandez > --- > arch/arm/boot/dts/stih415-pinctrl.dtsi | 16 ++++++++++++++++ > arch/arm/boot/dts/stih415.dtsi | 10 ++++++++++ > 2 files changed, 26 insertions(+) > + keyscan: keyscan at fe4b0000 { > + compatible = "st,keypad"; > + status = "disabled"; > + reg = <0xfe4b0000 0x2000>; > + interrupts = ; > + clocks = <&CLK_SYSIN>; > + pinctrl-names = "default"; Small nit here, but otherwise: Acked-by: Lee Jones > + pinctrl-0 = <&pinctrl_keyscan>; > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264AbaCJLu3 (ORCPT ); Mon, 10 Mar 2014 07:50:29 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:63043 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752651AbaCJLu1 (ORCPT ); Mon, 10 Mar 2014 07:50:27 -0400 Date: Mon, 10 Mar 2014 11:50:21 +0000 From: Lee Jones To: Gabriel FERNANDEZ Cc: Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Russell King , Grant Likely , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, kernel@stlinux.com, Giuseppe CONDORELLI Subject: Re: [PATCH 2/5] ARM: STi: DT: add keyscan for stih415 Message-ID: <20140310115021.GP14976@lee--X1> References: <1393990772-9567-1-git-send-email-gabriel.fernandez@st.com> <1393990772-9567-3-git-send-email-gabriel.fernandez@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1393990772-9567-3-git-send-email-gabriel.fernandez@st.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Giuseppe CONDORELLI > > Add keyscan support for stih415. > It is put disabled by default because it is not enabled on all boards > Also there are PIOs conflict with already claimed lines. > > Signed-off-by: Giuseppe Condorelli > Signed-off-by: Gabriel Fernandez > --- > arch/arm/boot/dts/stih415-pinctrl.dtsi | 16 ++++++++++++++++ > arch/arm/boot/dts/stih415.dtsi | 10 ++++++++++ > 2 files changed, 26 insertions(+) > + keyscan: keyscan@fe4b0000 { > + compatible = "st,keypad"; > + status = "disabled"; > + reg = <0xfe4b0000 0x2000>; > + interrupts = ; > + clocks = <&CLK_SYSIN>; > + pinctrl-names = "default"; Small nit here, but otherwise: Acked-by: Lee Jones > + pinctrl-0 = <&pinctrl_keyscan>; > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog