From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 3/3] perf trace: Decode architecture-specific signal numbers
Date: Mon, 10 Mar 2014 11:14:26 -0300 [thread overview]
Message-ID: <20140310141426.GB8859@ghostprotocols.net> (raw)
In-Reply-To: <1394373333.2861.84.camel@deadeye.wl.decadent.org.uk>
Em Sun, Mar 09, 2014 at 01:55:33PM +0000, Ben Hutchings escreveu:
> What's happening with this patch? perf fails to build on alpha or sparc
> since 3.13.
Grrr, I thought I had processed all of these, but this got missed, did
it now, will push soon.
- Arnaldo
> Ben.
>
> On Thu, 2014-02-06 at 01:00 +0000, Ben Hutchings wrote:
> > SIGSTKFLT is not defined on alpha, mips or sparc.
> > SIGEMT and SIGSWI are defined on some architectures and should be
> > decoded here if so.
> >
> > Fixes: 8bad5b0abfdb ('perf trace: Beautify signal number arg in several syscalls')
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > Cc: <stable@vger.kernel.org>
> > ---
> > tools/perf/builtin-trace.c | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > index 5c32dcf..25ea64c 100644
> > --- a/tools/perf/builtin-trace.c
> > +++ b/tools/perf/builtin-trace.c
> > @@ -807,7 +807,6 @@ static size_t syscall_arg__scnprintf_signum(char *bf, size_t size, struct syscal
> > P_SIGNUM(PIPE);
> > P_SIGNUM(ALRM);
> > P_SIGNUM(TERM);
> > - P_SIGNUM(STKFLT);
> > P_SIGNUM(CHLD);
> > P_SIGNUM(CONT);
> > P_SIGNUM(STOP);
> > @@ -823,6 +822,15 @@ static size_t syscall_arg__scnprintf_signum(char *bf, size_t size, struct syscal
> > P_SIGNUM(IO);
> > P_SIGNUM(PWR);
> > P_SIGNUM(SYS);
> > +#ifdef SIGEMT
> > + P_SIGNUM(EMT);
> > +#endif
> > +#ifdef SIGSTKFLT
> > + P_SIGNUM(STKFLT);
> > +#endif
> > +#ifdef SIGSWI
> > + P_SIGNUM(SWI);
> > +#endif
> > default: break;
> > }
> >
> >
>
> --
> Ben Hutchings
> I say we take off; nuke the site from orbit. It's the only way to be sure.
next prev parent reply other threads:[~2014-03-10 14:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 0:59 [PATCH 0/3] Fix perf build breakages in 3.13 Ben Hutchings
2014-02-06 1:00 ` [PATCH 1/3] Revert "perf trace: Initial beautifier for ioctl's 'cmd' arg" Ben Hutchings
2014-02-06 1:00 ` [PATCH 2/3] perf trace: Add fallback definition of EFD_SEMAPHORE Ben Hutchings
2014-02-22 17:55 ` [tip:perf/core] " tip-bot for Ben Hutchings
2014-02-06 1:00 ` [PATCH 3/3] perf trace: Decode architecture-specific signal numbers Ben Hutchings
2014-03-09 13:55 ` Ben Hutchings
2014-03-10 14:14 ` Arnaldo Carvalho de Melo [this message]
2014-03-11 10:16 ` [tip:perf/urgent] " tip-bot for Ben Hutchings
2014-02-06 13:41 ` [PATCH 0/3] Fix perf build breakages in 3.13 Arnaldo Carvalho de Melo
2014-02-06 13:48 ` Arnaldo Carvalho de Melo
2014-02-06 14:13 ` Ben Hutchings
2014-02-06 14:40 ` Arnaldo Carvalho de Melo
2014-02-10 17:52 ` Arnaldo Carvalho de Melo
2014-02-10 21:32 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310141426.GB8859@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.