From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Adrian Huang12 <ahuang12@lenovo.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/1] ACPI: Fix the incorrect behavior of the disabled ASPM on Haswell CPU
Date: Mon, 10 Mar 2014 15:45:30 +0000 [thread overview]
Message-ID: <20140310154530.GA27699@srcf.ucam.org> (raw)
In-Reply-To: <6366A95FCFBB78419E783DDD020ED2ECB2F134@APMAILMBX03.lenovo.com>
On Mon, Mar 10, 2014 at 09:56:25AM +0000, Adrian Huang12 wrote:
> + if (status == AE_NOT_FOUND &&
Why limit it to not found? I suspect that we should never be basing our
ASPM policy on the behaviour of PCI (rather than PCIe) bridges.
I'd recommend changing the patch subject line, too - there's nothing
Haswell specific about this.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2014-03-10 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 9:56 [PATCH 1/1] ACPI: Fix the incorrect behavior of the disabled ASPM on Haswell CPU Adrian Huang12
2014-03-10 15:45 ` Matthew Garrett [this message]
2014-03-10 16:17 ` Adrian Huang12
2014-03-10 16:24 ` Matthew Garrett
2014-03-13 12:22 ` Adrian Huang12
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310154530.GA27699@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=ahuang12@lenovo.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.