Re: [PATCH] arm64: iommu: Refactoring common code.

[Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>]

On Mon, Mar 10, 2014 at 04:32:50PM +0000, Ritesh Harjani wrote:
> Hi Everyone,
> 
> Please find the following patch as refactoring of the common code out
> from arch/arm/mm/dma-mapping.c to lib/iommu-helper.c
> 
> This is just an initial version of patch to get more details and to
> know if this is how we want to plan refactoring iommu code to
> lib/iommu-helper.
> 
> Please let me know the changes/suggestion which you think in this ?
> 
> 
> 
> 
> Taking out the common code of buffer allocation and mapping
> for iommu from arch/arm to lib/iommu-helper file.
> 
> Signed-off-by: Ritesh Harjani <ritesh.harjani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/mm/dma-mapping.c    | 159 +++++-----------------------------------
>  include/linux/iommu-helper.h |  22 ++++++
>  lib/iommu-helper.c           | 169 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 210 insertions(+), 140 deletions(-)

I haven't had the time to look at this patch but I think you should
change the subject prefix to just arm (rather than arm64) and cc Russell
King and the linux-arm-kernel mailing list.

I'll have a look at the patch tomorrow.

Thanks.

-- 
Catalin