From: "Michael S. Tsirkin" <mst@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH v2] q35: Correct typo BRDIGE -> BRIDGE
Date: Mon, 10 Mar 2014 21:05:55 +0200 [thread overview]
Message-ID: <20140310190555.GA16307@redhat.com> (raw)
In-Reply-To: <20140228104440.17ABD2F358@mono.eik.bme.hu>
On Fri, Feb 28, 2014 at 11:28:03AM +0100, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Applied, thanks!
> ---
>
> v2: Sorry, I was too fast to send it. Found two more places to change.
>
> hw/pci-host/q35.c | 10 +++++-----
> include/hw/i386/ich9.h | 2 +-
> include/hw/pci-host/q35.h | 24 ++++++++++++------------
> 3 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index 4bc2e01..8b8cc4e 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -272,7 +272,7 @@ static void mch_update_smram(MCHPCIState *mch)
> PCIDevice *pd = PCI_DEVICE(mch);
>
> memory_region_transaction_begin();
> - smram_update(&mch->smram_region, pd->config[MCH_HOST_BRDIGE_SMRAM],
> + smram_update(&mch->smram_region, pd->config[MCH_HOST_BRIDGE_SMRAM],
> mch->smm_enabled);
> memory_region_transaction_commit();
> }
> @@ -283,7 +283,7 @@ static void mch_set_smm(int smm, void *arg)
> PCIDevice *pd = PCI_DEVICE(mch);
>
> memory_region_transaction_begin();
> - smram_set_smm(&mch->smm_enabled, smm, pd->config[MCH_HOST_BRDIGE_SMRAM],
> + smram_set_smm(&mch->smm_enabled, smm, pd->config[MCH_HOST_BRIDGE_SMRAM],
> &mch->smram_region);
> memory_region_transaction_commit();
> }
> @@ -306,8 +306,8 @@ static void mch_write_config(PCIDevice *d,
> mch_update_pciexbar(mch);
> }
>
> - if (ranges_overlap(address, len, MCH_HOST_BRDIGE_SMRAM,
> - MCH_HOST_BRDIGE_SMRAM_SIZE)) {
> + if (ranges_overlap(address, len, MCH_HOST_BRIDGE_SMRAM,
> + MCH_HOST_BRIDGE_SMRAM_SIZE)) {
> mch_update_smram(mch);
> }
> }
> @@ -347,7 +347,7 @@ static void mch_reset(DeviceState *qdev)
> pci_set_quad(d->config + MCH_HOST_BRIDGE_PCIEXBAR,
> MCH_HOST_BRIDGE_PCIEXBAR_DEFAULT);
>
> - d->config[MCH_HOST_BRDIGE_SMRAM] = MCH_HOST_BRIDGE_SMRAM_DEFAULT;
> + d->config[MCH_HOST_BRIDGE_SMRAM] = MCH_HOST_BRIDGE_SMRAM_DEFAULT;
>
> mch_update(mch);
> }
> diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h
> index 9e4a0e4..e191435 100644
> --- a/include/hw/i386/ich9.h
> +++ b/include/hw/i386/ich9.h
> @@ -102,7 +102,7 @@ Object *ich9_lpc_find(void);
> #define ICH9_USB_UHCI1_DEV 29
> #define ICH9_USB_UHCI1_FUNC 0
>
> -/* D30:F0 DMI-to-PCI brdige */
> +/* D30:F0 DMI-to-PCI bridge */
> #define ICH9_D2P_BRIDGE "ICH9 D2P BRIDGE"
> #define ICH9_D2P_BRIDGE_SAVEVM_VERSION 0
>
> diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h
> index d0355b7..d9ee978 100644
> --- a/include/hw/pci-host/q35.h
> +++ b/include/hw/pci-host/q35.h
> @@ -125,8 +125,8 @@ typedef struct Q35PCIHost {
> #define MCH_HOST_BRIDGE_PAM_RE ((uint8_t)0x1)
> #define MCH_HOST_BRIDGE_PAM_MASK ((uint8_t)0x3)
>
> -#define MCH_HOST_BRDIGE_SMRAM 0x9d
> -#define MCH_HOST_BRDIGE_SMRAM_SIZE 1
> +#define MCH_HOST_BRIDGE_SMRAM 0x9d
> +#define MCH_HOST_BRIDGE_SMRAM_SIZE 1
> #define MCH_HOST_BRIDGE_SMRAM_DEFAULT ((uint8_t)0x2)
> #define MCH_HOST_BRIDGE_SMRAM_D_OPEN ((uint8_t)(1 << 6))
> #define MCH_HOST_BRIDGE_SMRAM_D_CLS ((uint8_t)(1 << 5))
> @@ -140,16 +140,16 @@ typedef struct Q35PCIHost {
> #define MCH_HOST_BRIDGE_UPPER_SYSTEM_BIOS_END 0x100000
>
> #define MCH_HOST_BRIDGE_ESMRAMC 0x9e
> -#define MCH_HOST_BRDIGE_ESMRAMC_H_SMRAME ((uint8_t)(1 << 6))
> -#define MCH_HOST_BRDIGE_ESMRAMC_E_SMERR ((uint8_t)(1 << 5))
> -#define MCH_HOST_BRDIGE_ESMRAMC_SM_CACHE ((uint8_t)(1 << 4))
> -#define MCH_HOST_BRDIGE_ESMRAMC_SM_L1 ((uint8_t)(1 << 3))
> -#define MCH_HOST_BRDIGE_ESMRAMC_SM_L2 ((uint8_t)(1 << 2))
> -#define MCH_HOST_BRDIGE_ESMRAMC_TSEG_SZ_MASK ((uint8_t)(0x3 << 1))
> -#define MCH_HOST_BRDIGE_ESMRAMC_TSEG_SZ_1MB ((uint8_t)(0x0 << 1))
> -#define MCH_HOST_BRDIGE_ESMRAMC_TSEG_SZ_2MB ((uint8_t)(0x1 << 1))
> -#define MCH_HOST_BRDIGE_ESMRAMC_TSEG_SZ_8MB ((uint8_t)(0x2 << 1))
> -#define MCH_HOST_BRDIGE_ESMRAMC_T_EN ((uint8_t)1)
> +#define MCH_HOST_BRIDGE_ESMRAMC_H_SMRAME ((uint8_t)(1 << 6))
> +#define MCH_HOST_BRIDGE_ESMRAMC_E_SMERR ((uint8_t)(1 << 5))
> +#define MCH_HOST_BRIDGE_ESMRAMC_SM_CACHE ((uint8_t)(1 << 4))
> +#define MCH_HOST_BRIDGE_ESMRAMC_SM_L1 ((uint8_t)(1 << 3))
> +#define MCH_HOST_BRIDGE_ESMRAMC_SM_L2 ((uint8_t)(1 << 2))
> +#define MCH_HOST_BRIDGE_ESMRAMC_TSEG_SZ_MASK ((uint8_t)(0x3 << 1))
> +#define MCH_HOST_BRIDGE_ESMRAMC_TSEG_SZ_1MB ((uint8_t)(0x0 << 1))
> +#define MCH_HOST_BRIDGE_ESMRAMC_TSEG_SZ_2MB ((uint8_t)(0x1 << 1))
> +#define MCH_HOST_BRIDGE_ESMRAMC_TSEG_SZ_8MB ((uint8_t)(0x2 << 1))
> +#define MCH_HOST_BRIDGE_ESMRAMC_T_EN ((uint8_t)1)
>
> /* D1:F0 PCIE* port*/
> #define MCH_PCIE_DEV 1
> --
> 1.8.1.5
prev parent reply other threads:[~2014-03-10 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 10:28 [Qemu-devel] [PATCH v2] q35: Correct typo BRDIGE -> BRIDGE BALATON Zoltan
2014-03-10 18:38 ` [Qemu-trivial] " BALATON Zoltan
2014-03-10 18:38 ` BALATON Zoltan
2014-03-14 15:56 ` [Qemu-trivial] " Michael Tokarev
2014-03-14 15:56 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-14 17:52 ` [Qemu-trivial] [Qemu-devel] " BALATON Zoltan
2014-03-14 17:52 ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
2014-03-10 19:05 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310190555.GA16307@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.