Re: [PATCH 1/4] drm/i915: Make encoder cloning more flexible

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Mar 10, 2014 at 03:27:09PM -0300, Rodrigo Vivi wrote:
> On Mon, Mar 3, 2014 at 11:15 AM,  <ville.syrjala@linux.intel.com> wrote:
> > diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
> > index b64fc1c..5be4ab2 100644
> > --- a/drivers/gpu/drm/i915/intel_tv.c
> > +++ b/drivers/gpu/drm/i915/intel_tv.c
> > @@ -1639,9 +1639,8 @@ intel_tv_init(struct drm_device *dev)
> >         intel_connector_attach_encoder(intel_connector, intel_encoder);
> >         intel_encoder->type = INTEL_OUTPUT_TVOUT;
> >         intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
> > -       intel_encoder->cloneable = false;
> > +       intel_encoder->cloneable = 0;
> >         intel_encoder->base.possible_crtcs = ((1 << 0) | (1 << 1));
> > -       intel_encoder->base.possible_clones = (1 << INTEL_OUTPUT_TVOUT);
> 
> why did you remove this?
> or shouldn't it be a separated patch at least?

It has no business being here. We compute possible_clones dynamically
so this will get overwritten. I forgot to mention it in the commits
msg. It could be a separate patch, but since it does nothing just
killing it as part of this patch seems fine.

> 
> The rest of the approach looks ok for me, so with this explained or
> fixed feel free to use
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> 
> >         intel_tv->type = DRM_MODE_CONNECTOR_Unknown;
> >
> >         /* BIOS margin values */
> > --
> > 1.8.3.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> 
> 
> -- 
> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br

-- 
Ville Syrjälä
Intel OTC