From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com, namhyung@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/8] perf, tools: Add --branch-history option to report v2
Date: Tue, 11 Mar 2014 01:31:54 +0100 [thread overview]
Message-ID: <20140311003154.GP22728@two.firstfloor.org> (raw)
In-Reply-To: <20140307131940.GB13974@krava.brq.redhat.com>
> this is *same* as parse_branch_mode function and seems to be not needed,
> I think both branch-stack and branch-history options could be handled
> by OPT_BOOLEAN
They can't because the type checker requires bool, and these variables
are tristate (UNSET, TRUE, FALSE)
-Andi
next prev parent reply other threads:[~2014-03-11 0:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 4:22 perf: Implement lbr-as-callgraph v4 Andi Kleen
2014-02-28 4:22 ` [PATCH 1/8] perf, tools: fix BFD detection on opensuse Andi Kleen
2014-02-28 4:22 ` [PATCH 2/8] perf, tools: Support handling complete branch stacks as histograms v4 Andi Kleen
2014-03-05 10:29 ` Jiri Olsa
2014-03-05 15:31 ` Andi Kleen
2014-03-07 13:19 ` Jiri Olsa
2014-03-07 13:19 ` Jiri Olsa
2014-03-07 19:51 ` Arnaldo Carvalho de Melo
2014-03-07 19:54 ` Arnaldo Carvalho de Melo
2014-03-11 0:43 ` Andi Kleen
2014-02-28 4:22 ` [PATCH 3/8] perf, tools: Add --branch-history option to report v2 Andi Kleen
2014-03-07 13:19 ` Jiri Olsa
2014-03-11 0:31 ` Andi Kleen [this message]
2014-03-11 15:25 ` Jiri Olsa
2014-03-11 20:21 ` Andi Kleen
2014-02-28 4:22 ` [PATCH 4/8] perf, tools: Enable printing the srcline in the history v2 Andi Kleen
2014-03-01 16:22 ` Andi Kleen
2014-02-28 4:22 ` [PATCH 5/8] perf, tools: Only print base source file for srcline Andi Kleen
2014-02-28 4:22 ` [PATCH 6/8] perf, tools: Support source line numbers in annotate Andi Kleen
2014-02-28 4:22 ` [PATCH 7/8] perf, tools: Fix srcline sort key output to use width Andi Kleen
2014-02-28 4:22 ` [PATCH 8/8] tools, perf: Make get_srcline fall back to sym+offset Andi Kleen
2014-03-07 13:19 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311003154.GP22728@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.