All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Christoph Lameter <cl@linux.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Pekka Enberg <penberg@kernel.org>,
	linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: oops in slab/leaks_show
Date: Mon, 10 Mar 2014 20:39:54 -0400	[thread overview]
Message-ID: <20140311003954.GA4798@redhat.com> (raw)
In-Reply-To: <20140311003459.GA25657@lge.com>

On Tue, Mar 11, 2014 at 09:35:00AM +0900, Joonsoo Kim wrote:
 > On Fri, Mar 07, 2014 at 11:18:30AM -0600, Christoph Lameter wrote:
 > > Joonsoo recently changed the handling of the freelist in SLAB. CCing him.
 > > 
 > > On Thu, 6 Mar 2014, Dave Jones wrote:
 > > 
 > > > I pretty much always use SLUB for my fuzzing boxes, but thought I'd give SLAB a try
 > > > for a change.. It blew up when something tried to read /proc/slab_allocators
 > > > (Just cat it, and you should see the oops below)
 > 
 > Hello, Dave.
 > 
 > Today, I did a test on v3.13 which contains all my changes on the handling of
 > the freelist in SLAB and couldn't trigger oops by just 'cat /proc/slab_allocators'.
 > 
 > So I look at the code and find that there is race window if there is multiple users
 > doing 'cat /proc/slab_allocators'. Did your test do that?

I could reproduce it with a single cat.

	Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Christoph Lameter <cl@linux.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Pekka Enberg <penberg@kernel.org>,
	linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: oops in slab/leaks_show
Date: Mon, 10 Mar 2014 20:39:54 -0400	[thread overview]
Message-ID: <20140311003954.GA4798@redhat.com> (raw)
In-Reply-To: <20140311003459.GA25657@lge.com>

On Tue, Mar 11, 2014 at 09:35:00AM +0900, Joonsoo Kim wrote:
 > On Fri, Mar 07, 2014 at 11:18:30AM -0600, Christoph Lameter wrote:
 > > Joonsoo recently changed the handling of the freelist in SLAB. CCing him.
 > > 
 > > On Thu, 6 Mar 2014, Dave Jones wrote:
 > > 
 > > > I pretty much always use SLUB for my fuzzing boxes, but thought I'd give SLAB a try
 > > > for a change.. It blew up when something tried to read /proc/slab_allocators
 > > > (Just cat it, and you should see the oops below)
 > 
 > Hello, Dave.
 > 
 > Today, I did a test on v3.13 which contains all my changes on the handling of
 > the freelist in SLAB and couldn't trigger oops by just 'cat /proc/slab_allocators'.
 > 
 > So I look at the code and find that there is race window if there is multiple users
 > doing 'cat /proc/slab_allocators'. Did your test do that?

I could reproduce it with a single cat.

	Dave


  reply	other threads:[~2014-03-11  0:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07  2:57 oops in slab/leaks_show Dave Jones
2014-03-07  2:57 ` Dave Jones
2014-03-07 17:18 ` Christoph Lameter
2014-03-07 17:18   ` Christoph Lameter
2014-03-11  0:35   ` Joonsoo Kim
2014-03-11  0:35     ` Joonsoo Kim
2014-03-11  0:39     ` Dave Jones [this message]
2014-03-11  0:39       ` Dave Jones
2014-03-11  1:01     ` Joonsoo Kim
2014-03-11  1:01       ` Joonsoo Kim
2014-03-11  1:24       ` Dave Jones
2014-03-11  1:24         ` Dave Jones
2014-03-11  2:58         ` Joonsoo Kim
2014-03-11  2:58           ` Joonsoo Kim
2014-03-11  8:30           ` Joonsoo Kim
2014-03-11  8:30             ` Joonsoo Kim
2014-04-11  7:36             ` Pekka Enberg
2014-04-11  7:36               ` Pekka Enberg
2014-04-16  0:07               ` Joonsoo Kim
2014-04-16  0:07                 ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311003954.GA4798@redhat.com \
    --to=davej@redhat.com \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.