From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH 4/4 v2] tools/xc: pass errno to callers of
	xc_domain_save
Date: Tue, 11 Mar 2014 08:49:48 +0100
Message-ID: <20140311074948.GA5645@aepfle.de>
References: <1394183709-9956-1-git-send-email-olaf@aepfle.de>
	<1394183709-9956-5-git-send-email-olaf@aepfle.de>
	<21277.61301.269725.74179@mariner.uk.xensource.com>
	<20140310182436.GA24517@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20140310182436.GA24517@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian.Campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, Mar 10, Olaf Hering wrote:

> On Mon, Mar 10, Ian Jackson wrote:
> 
> > Can I suggest that these cases could probably benefit from
> >     assert(errno)
> 
> I think that verifying errno in that case is a good thing. But:
> Wouldnt that abort() applications using libxc, including libvirtd?

I see that libxl contains many assert(), so one more would probably not
hurt.

Olaf