From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jespern@axis.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-cris-kernel <linux-cris-kernel@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cris: Convert ffs from an object-like macro to a function-like macro
Date: Tue, 11 Mar 2014 09:43:39 +0100 [thread overview]
Message-ID: <20140311084339.GY25718@axis.com> (raw)
In-Reply-To: <1394457733-7141-1-git-send-email-geert@linux-m68k.org>
On Mon, Mar 10, 2014 at 02:22:13PM +0100, Geert Uytterhoeven wrote:
> This avoids bad interactions with code using identifiers called "ffs":
>
> drivers/usb/gadget/f_fs.c: In function 'ffsmod_init':
> drivers/usb/gadget/f_fs.c:2693:494: error: 'ffsusb_func' undeclared (first use in this function)
> drivers/usb/gadget/f_fs.c:2693:494: note: each undeclared identifier is reported only once for each function it appears in
> drivers/usb/gadget/f_fs.c: In function 'ffsmod_exit':
> drivers/usb/gadget/f_fs.c:2693:677: error: 'ffsusb_func' undeclared (first use in this function)
> drivers/usb/gadget/f_fs.c: At top level:
> drivers/usb/gadget/f_fs.c:2693:35: warning: 'kernel_ffsusb_func' defined but not used [-Wunused-variable]
> drivers/usb/gadget/f_fs.c: In function 'ffsmod_init':
> drivers/usb/gadget/f_fs.c:2693:15: warning: control reaches end of non-void function [-Wreturn-type]
Yup, quite right. Andrew already added it to his queue,
but for the mailing archives here's my:
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2014-03-11 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 13:22 [PATCH] cris: Convert ffs from an object-like macro to a function-like macro Geert Uytterhoeven
2014-03-11 8:43 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311084339.GY25718@axis.com \
--to=jesper.nilsson@axis.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=jespern@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.