From: Ingo Molnar <mingo@kernel.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Rui Wang <rui.y.wang@intel.com>,
Liu Ping Fan <kernelfans@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>,
Lv Zheng <lv.zheng@intel.com>,
Seiji Aguchi <seiji.aguchi@hds.com>,
Yang Zhang <yang.z.zhang@intel.com>,
Andi Kleen <ak@linux.intel.com>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
Li Fei <fei.li@intel.com>,
gong.chen@linux.intel.com
Subject: Re: [PATCH] x86, fix x86 fixup_irqs() error handling [v2]
Date: Tue, 11 Mar 2014 12:11:56 +0100 [thread overview]
Message-ID: <20140311111156.GB27009@gmail.com> (raw)
In-Reply-To: <1394111467-3351-1-git-send-email-prarit@redhat.com>
* Prarit Bhargava <prarit@redhat.com> wrote:
> fixup_irqs() calls chip->set_irq_affinity which eventually calls
> __assign_irq_vector(). Errors are not propogated back from this function call
> and this results in silent irq relocation failures. This patch fixes this
> issue and prints out a warning if there is a relocation failure.
>
> [v2]: modified WARN to pr_crit and changed message
Please fix the changelog to conform to the standard changelog style:
- first describe the symptoms of the bug - how does a user notice?
- then describe how the code behaves today and how that is causing the bug
- and then only describe how it's fixed.
The first item is the most important one - yet it's missing from this
changelog.
Thanks,
Ingo
next prev parent reply other threads:[~2014-03-11 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 20:04 [PATCH] x86, fix x86 fixup_irqs() error handling Prarit Bhargava
2014-03-05 21:09 ` David Rientjes
2014-03-05 22:57 ` Prarit Bhargava
2014-03-06 10:22 ` Thomas Gleixner
2014-03-06 13:11 ` [PATCH] x86, fix x86 fixup_irqs() error handling [v2] Prarit Bhargava
2014-03-11 11:11 ` Ingo Molnar [this message]
2014-03-11 12:05 ` [PATCH] x86, fix x86 fixup_irqs() error handling [v3] Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311111156.GB27009@gmail.com \
--to=mingo@kernel.org \
--cc=ak@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=fei.li@intel.com \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rui.y.wang@intel.com \
--cc=seiji.aguchi@hds.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yang.z.zhang@intel.com \
--cc=yoshihiro.yunomae.ez@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.