From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] boards.cfg: move boards with invalid emails to Orphan
Date: Tue, 11 Mar 2014 08:26:41 -0400 [thread overview]
Message-ID: <20140311122641.GL16805@bill-the-cat> (raw)
In-Reply-To: <20140311203136.6F29.AA925319@jp.panasonic.com>
On Tue, Mar 11, 2014 at 08:31:37PM +0900, Masahiro Yamada wrote:
> Hello Albert,
>
> > > Besides, Orphan boards have been collected at the bottom of boards.cfg.
> > > (This is done when we run "tools/reformat.py")
> > >
> > > Add separators to distinguish them from those which
> > > were moved to Orphan 6 months ago.
> > > I believe it will be helpful in future to find which boards are
> > > old enough to be removed from the code base.
> >
> > Agreed up to and including the above. However, it seems you have not
> > applied tools/reformat.py as requested in the file header: after
> > I have applied your patch, running reformat.py led to some lines being
> > reorganized in boards.cfg.
>
> Yes. It is intentinal.
> I think touching other boards is beyond the scope of this patch
> and obscures the purpose of this patch.
Yes, all of Masahiro's changes are correctly formatted within the file
(just confirmed that). I'll do a follow-up reformat and apply on top as
it's a separate change, that does need doing, but isn't part of this.
Thanks guys!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140311/c53678c1/attachment.pgp>
next prev parent reply other threads:[~2014-03-11 12:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 3:19 [U-Boot] [PATCH v2] boards.cfg: move boards with invalid emails to Orphan Masahiro Yamada
2014-03-11 11:00 ` Albert ARIBAUD
2014-03-11 11:31 ` Masahiro Yamada
2014-03-11 11:58 ` Albert ARIBAUD
2014-03-11 12:26 ` Tom Rini [this message]
2014-03-11 12:29 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311122641.GL16805@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.