From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: Qualcomm PMIC8XXX keypad never worked? Date: Tue, 11 Mar 2014 13:06:09 +0000 Message-ID: <20140311130609.GL21216@lee--X1> References: <5887114.1jrNo21sGX@wuerfel> <20140311120056.GH21216@lee--X1> <8206209.oc1V5pPVYT@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <8206209.oc1V5pPVYT@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: Trilok Soni , Samuel Ortiz , Dmitry Torokhov , Stephen Boyd , linux-kernel@vger.kernel.org, Anirudh Ghayal , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-input@vger.kernel.org PiA+ID4gU29tZXRoaW5nIGluIHRoZSBNRkRfUE04WFhYIGRyaXZlciBtdXN0IGhhdmUgY2hhbmdl ZCByZWNlbnRseSB0aGF0IG5vdyBhbGxvd3MKPiA+ID4gdGhlIEtFWUJPQVJEX1BNSUM4WFhYIGRy aXZlciB0byBiZSBlbmFibGVkLiBVbmZvcnR1bmF0ZWx5LCBpdCBkb2VzIG5vdCBidWlsZAo+ID4g PiBiZWNhdXNlIG9mIGEgZGVwZW5kZW5jeSBvbiB0aGUgPGxpbnV4L21mZC9wbTh4eHgvZ3Bpby5o PiBoZWFkZXIgZmlsZSB0aGF0Cj4gPiA+IGRvZXMgbm90IGV4aXN0Lgo+ID4gCj4gPiBJIGhhdmUg aXQ/Cj4gPiAKPiA+IC1ydy1yLS1yLS0gMSBsZWUgbGVlIDIxNDcgRGVjIDE4IDExOjUyIGluY2x1 ZGUvbGludXgvbWZkL3BtOHh4eC9jb3JlLmgKPiAKPiBUaGlzIGlzIGNvcmUuaCwgbm90IGdwaW8u aAoKSG1tbS4uLiBzbyBpdCBpcy4gSSB0aGluayBJJ20gZ29pbmcgc2VuaWxlIQoKPiA+ID4gSW4g b3JkZXIgdG8ga2VlcCAnbWFrZSByYW5kY29uZmlnJyB3b3JraW5nIG9uIG15IHRlc3QgYm94LCBJ IGhhdmUgZGlzYWJsZWQKPiA+ID4gdGhpcyBkcml2ZXIsIGJ1dCBpdCB3b3VsZCBiZSBuaWNlIG9m IHNvbWVvbmUgY291bGQgaGF2ZSBhIGxvb2sgaW50byBmaXhpbmcgaXQuCj4gPiAKPiA+IENhbiB5 b3Ugc2VuZCBtZSB0aGUgY29uZmlnIHRoYXQgYnJlYWtzIHBsZWFzZT8KPiAKPiBhcHBlbmRlZCBi ZWxvdy4gWW91IG1pZ2h0IG5lZWQgbW9yZSBwYXRjaGVzIHRvIGJ1aWxkIHRoaXMsIGJ1dCB5b3Ug d2lsbCBnZXQgdGhlCj4gZXJyb3IgaWYgeW91IGp1c3QgdHJ5IGJ1aWxkaW5nIHRoZSBpbnB1dCBk cml2ZXIuCgpPa2F5LCBJJ3ZlIHJlY3JlYXRlZCB0aGUgZXJyb3IuCgpJIHRoaW5rIGl0J3MgdGhp cyBjb21taXQgdGhhdCdzIGNhdXNpbmcgeW91ciBlcnJvcjoKCiAgaHR0cHM6Ly9sa21sLm9yZy9s a21sLzIwMTMvMTIvMTAvOTAzCgouLi4gYnV0IHRoZSBNRkQgaXNuJ3QgYnJva2VuLCBzbyBJIGd1 ZXNzIHlvdXIgc29sdXRpb24gaXMgdGhlIG1vc3QKZWxlZ2FudC4gSWYgaXQncyBub3QgZml4ZWQg c29vbiwgSSBndWVzcyB3ZSBzaG91bGQgdGhpbmsgYWJvdXQgcmlwcGluZwppdCBvdXQuIEl0J3Mg b2J2b2lvdXMgdGhhdCBuby1vbmUgY2FyZXMsIGFzIGl0J3MgYmVlbiBicm9rZW4gZm9yCm5lYXJs eSAzIHllYXJzLgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1RNaWNyb2VsZWN0cm9uaWNzIExhbmRp bmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0g U29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 11 Mar 2014 13:06:09 +0000 Subject: Qualcomm PMIC8XXX keypad never worked? In-Reply-To: <8206209.oc1V5pPVYT@wuerfel> References: <5887114.1jrNo21sGX@wuerfel> <20140311120056.GH21216@lee--X1> <8206209.oc1V5pPVYT@wuerfel> Message-ID: <20140311130609.GL21216@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > > Something in the MFD_PM8XXX driver must have changed recently that now allows > > > the KEYBOARD_PMIC8XXX driver to be enabled. Unfortunately, it does not build > > > because of a dependency on the header file that > > > does not exist. > > > > I have it? > > > > -rw-r--r-- 1 lee lee 2147 Dec 18 11:52 include/linux/mfd/pm8xxx/core.h > > This is core.h, not gpio.h Hmmm... so it is. I think I'm going senile! > > > In order to keep 'make randconfig' working on my test box, I have disabled > > > this driver, but it would be nice of someone could have a look into fixing it. > > > > Can you send me the config that breaks please? > > appended below. You might need more patches to build this, but you will get the > error if you just try building the input driver. Okay, I've recreated the error. I think it's this commit that's causing your error: https://lkml.org/lkml/2013/12/10/903 ... but the MFD isn't broken, so I guess your solution is the most elegant. If it's not fixed soon, I guess we should think about ripping it out. It's obvoious that no-one cares, as it's been broken for nearly 3 years. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog