All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Zhi Zou <zzou@redhat.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] vmcore-dmesg stack smashing happend in extreme case
Date: Tue, 11 Mar 2014 09:37:10 -0400	[thread overview]
Message-ID: <20140311133710.GA14785@redhat.com> (raw)
In-Reply-To: <1671814704.13309372.1394502138298.JavaMail.zimbra@redhat.com>

On Mon, Mar 10, 2014 at 09:42:18PM -0400, Zhi Zou wrote:

[..]
> > 
> > And we don't have to do this twice. Just do it once inside innermost
> > for loop.
> 
> At the beginning, I think it is unnecessary to do this twice too. But
> if the text_len ==0  then the for loop won't be executed and check won't
> be executed either. May be this situation never come up, considering it's
> cost, I can accept it because most of time we just do the check instead of
> write. If it is sure that text_len == 0 never come up, then we should remove
> it.

When do we get text_len=0? If text_len=0, then we are just printing time
stamp? Does it really happen?

I think do a quick test and if we are not encountering such cases, don't
worry about it right now. Making logic too complicated does not help.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

      reply	other threads:[~2014-03-11 13:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  9:25 [PATCH] vmcore-dmesg stack smashing happend in extreme case arthur
2014-03-10 21:16 ` Vivek Goyal
2014-03-11  1:42   ` Zhi Zou
2014-03-11 13:37     ` Vivek Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311133710.GA14785@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=zzou@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.