From: Michal Hocko <mhocko@suse.cz>
To: Matthias Wirth <matthias.wirth@gmail.com>
Cc: Lukas Senger <lukas@fridolin.com>,
Matthew Wilcox <matthew@wil.cx>, Jeff Layton <jlayton@redhat.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>, Lisa Du <cldu@marvell.com>,
Paul Mackerras <paulus@samba.org>,
Sasha Levin <sasha.levin@oracle.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Shaohua Li <shli@kernel.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Minchan Kim <minchan@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Steven Whitehouse <swhiteho@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Cody P Schafer <cody@linux.vnet.ibm.com>,
Jiang Liu <liuj97@gmail.com>,
David Rientjes <rientjes@google.com>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Subject: Re: [PATCH] mm: implement POSIX_FADV_NOREUSE
Date: Tue, 11 Mar 2014 15:06:55 +0100 [thread overview]
Message-ID: <20140311140655.GD28292@dhcp22.suse.cz> (raw)
In-Reply-To: <1394533550-18485-1-git-send-email-matthias.wirth@gmail.com>
On Tue 11-03-14 11:25:41, Matthias Wirth wrote:
> Backups, logrotation and indexers don't need files they read to remain
> in the page cache. Their pages can be reclaimed early and should not
> displace useful pages. POSIX specifices the POSIX_FADV_NOREUSE flag for
> these use cases but it's currently a noop.
Why don't you use POSIX_FADV_DONTNEED when you no longer use those
pages? E.g. on close()?
> In our implementation pages marked with the NoReuse flag are added to
> the tail of the LRU list the first time they are read. Therefore they
> are the first to be reclaimed.
page flags are really scarce and I am not sure this is the best usage of
the few remaining slots.
> We needed to add flags to the file and page structs in order to pass
> down the hint to the actual call to list_add.
>
> Signed-off-by: Matthias Wirth <matthias.wirth@gmail.com>
> Signed-off-by: Lukas Senger <lukas@fridolin.com>
[...]
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz>
To: Matthias Wirth <matthias.wirth@gmail.com>
Cc: Lukas Senger <lukas@fridolin.com>,
Matthew Wilcox <matthew@wil.cx>, Jeff Layton <jlayton@redhat.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>, Lisa Du <cldu@marvell.com>,
Paul Mackerras <paulus@samba.org>,
Sasha Levin <sasha.levin@oracle.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Shaohua Li <shli@kernel.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Minchan Kim <minchan@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Steven Whitehouse <swhiteho@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Cody P Schafer <cody@linux.vnet.ibm.com>,
Jiang Liu <liuj97@gmail.com>,
David Rientjes <rientjes@google.com>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Lukas Czerner <lczerner@redhat.com>,
Damien Ramonda <damien.ramonda@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: implement POSIX_FADV_NOREUSE
Date: Tue, 11 Mar 2014 15:06:55 +0100 [thread overview]
Message-ID: <20140311140655.GD28292@dhcp22.suse.cz> (raw)
In-Reply-To: <1394533550-18485-1-git-send-email-matthias.wirth@gmail.com>
On Tue 11-03-14 11:25:41, Matthias Wirth wrote:
> Backups, logrotation and indexers don't need files they read to remain
> in the page cache. Their pages can be reclaimed early and should not
> displace useful pages. POSIX specifices the POSIX_FADV_NOREUSE flag for
> these use cases but it's currently a noop.
Why don't you use POSIX_FADV_DONTNEED when you no longer use those
pages? E.g. on close()?
> In our implementation pages marked with the NoReuse flag are added to
> the tail of the LRU list the first time they are read. Therefore they
> are the first to be reclaimed.
page flags are really scarce and I am not sure this is the best usage of
the few remaining slots.
> We needed to add flags to the file and page structs in order to pass
> down the hint to the actual call to list_add.
>
> Signed-off-by: Matthias Wirth <matthias.wirth@gmail.com>
> Signed-off-by: Lukas Senger <lukas@fridolin.com>
[...]
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-11 14:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 10:25 [PATCH] mm: implement POSIX_FADV_NOREUSE Matthias Wirth
2014-03-11 10:25 ` Matthias Wirth
2014-03-11 14:06 ` Michal Hocko [this message]
2014-03-11 14:06 ` Michal Hocko
2014-03-11 15:24 ` Dave Hansen
2014-03-11 15:24 ` Dave Hansen
2014-03-11 21:27 ` Andrew Morton
2014-03-11 21:27 ` Andrew Morton
2014-03-12 11:59 ` Lukas Senger
2014-03-12 11:59 ` Lukas Senger
2014-03-12 14:46 ` Michal Hocko
2014-03-12 14:46 ` Michal Hocko
2014-03-12 16:05 ` Dave Hansen
2014-03-12 16:05 ` Dave Hansen
2014-03-13 12:40 ` Lukas Senger
2014-03-13 12:40 ` Lukas Senger
2014-03-13 18:43 ` [PATCHv2] " Matthias Wirth
2014-03-13 18:43 ` Matthias Wirth
2014-03-13 20:01 ` Andrew Morton
2014-03-13 20:01 ` Andrew Morton
2014-03-14 12:34 ` Lukas Senger
2014-03-14 12:34 ` Lukas Senger
2014-03-14 15:52 ` [PATCHv3] " Matthias Wirth
2014-03-14 15:52 ` Matthias Wirth
2014-03-18 15:14 ` Michal Hocko
2014-03-18 15:14 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311140655.GD28292@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bfields@fieldses.org \
--cc=cldu@marvell.com \
--cc=cody@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=jlayton@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=liuj97@gmail.com \
--cc=lukas@fridolin.com \
--cc=matthew@wil.cx \
--cc=matthias.wirth@gmail.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=paulus@samba.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=shli@kernel.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=swhiteho@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.