From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 5/6] pci: Use #defines for PCI vendors. Date: Tue, 11 Mar 2014 11:15:57 -0400 Message-ID: <20140311151557.GI13345@phenom.dumpdata.com> References: <1394480131-8083-1-git-send-email-konrad.wilk@oracle.com> <1394480131-8083-6-git-send-email-konrad.wilk@oracle.com> <531ED8EA0200007800122ABD@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WNOPY-0004GG-CD for xen-devel@lists.xenproject.org; Tue, 11 Mar 2014 15:16:08 +0000 Content-Disposition: inline In-Reply-To: <531ED8EA0200007800122ABD@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Konrad Rzeszutek Wilk , aravind.gopalakrishnan@amd.com, xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, Mar 11, 2014 at 08:35:38AM +0000, Jan Beulich wrote: > >>> On 10.03.14 at 20:35, Konrad Rzeszutek Wilk wrote: > > --- /dev/null > > +++ b/xen/include/xen/pci_ids.h > > @@ -0,0 +1,9 @@ > > +#define PCI_VENDOR_ID_AMD 0x1022 > > + > > +#define PCI_VENDOR_ID_BROADCOM 0x14e4 > > + > > +#define PCI_VENDOR_ID_INTEL 0x8086 > > + > > +#define PCI_VENDOR_ID_NVIDIA 0x10de > > + > > +#define PCI_VENDOR_ID_OXSEMI 0x1415 > > If I'm going to be the one to commit this (and I don't forget), I'll > take the liberty of sorting these numerically, matching Linux and > making imo lookup easier, since especially considering company > acquires/mergers the name to look for may be ambiguous. Of course. I think I am depending on you to merge them as I don't have the commit access. If you would like, I can pluck them in a git tree with this above fixed and your Reviewed-by added and I can just send you a GIT PULL request. Thank you! > > Jan >