From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 11 Mar 2014 16:08:37 +0000 Subject: [PATCH v3 2/5] mfd: add bcm590xx pmu driver In-Reply-To: <1394552775-31264-3-git-send-email-mporter@linaro.org> References: <1394552775-31264-1-git-send-email-mporter@linaro.org> <1394552775-31264-3-git-send-email-mporter@linaro.org> Message-ID: <20140311160837.GP21216@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > Add a driver for the BCM590xx PMU multi-function devices. The driver > initially supports regmap initialization and instantiation of the > voltage regulator device function of the PMU. > > Signed-off-by: Matt Porter > Reviewed-by: Tim Kryger > Reviewed-by: Markus Mayer > --- > drivers/mfd/Kconfig | 8 ++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/bcm590xx.h | 31 +++++++++++++++ > 4 files changed, 133 insertions(+) > create mode 100644 drivers/mfd/bcm590xx.c > create mode 100644 include/linux/mfd/bcm590xx.h I have a tiny nit that 'ret' doesn't need to be initialised before use in probe(), but apart from that... Looks pretty sensible: Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 2/5] mfd: add bcm590xx pmu driver Date: Tue, 11 Mar 2014 16:08:37 +0000 Message-ID: <20140311160837.GP21216@lee--X1> References: <1394552775-31264-1-git-send-email-mporter@linaro.org> <1394552775-31264-3-git-send-email-mporter@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1394552775-31264-3-git-send-email-mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Porter Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Samuel Ortiz , Liam Girdwood , Mark Brown , Christian Daudt , Devicetree List , Linux ARM Kernel List , Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org > Add a driver for the BCM590xx PMU multi-function devices. The driver > initially supports regmap initialization and instantiation of the > voltage regulator device function of the PMU. >=20 > Signed-off-by: Matt Porter > Reviewed-by: Tim Kryger > Reviewed-by: Markus Mayer > --- > drivers/mfd/Kconfig | 8 ++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++= ++++++++++ > include/linux/mfd/bcm590xx.h | 31 +++++++++++++++ > 4 files changed, 133 insertions(+) > create mode 100644 drivers/mfd/bcm590xx.c > create mode 100644 include/linux/mfd/bcm590xx.h I have a tiny nit that 'ret' doesn't need to be initialised before use in probe(), but apart from that... Looks pretty sensible: Acked-by: Lee Jones --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754711AbaCKQIp (ORCPT ); Tue, 11 Mar 2014 12:08:45 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:49203 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754565AbaCKQIn (ORCPT ); Tue, 11 Mar 2014 12:08:43 -0400 Date: Tue, 11 Mar 2014 16:08:37 +0000 From: Lee Jones To: Matt Porter Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Samuel Ortiz , Liam Girdwood , Mark Brown , Christian Daudt , Devicetree List , Linux ARM Kernel List , Linux Kernel Mailing List Subject: Re: [PATCH v3 2/5] mfd: add bcm590xx pmu driver Message-ID: <20140311160837.GP21216@lee--X1> References: <1394552775-31264-1-git-send-email-mporter@linaro.org> <1394552775-31264-3-git-send-email-mporter@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1394552775-31264-3-git-send-email-mporter@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Add a driver for the BCM590xx PMU multi-function devices. The driver > initially supports regmap initialization and instantiation of the > voltage regulator device function of the PMU. > > Signed-off-by: Matt Porter > Reviewed-by: Tim Kryger > Reviewed-by: Markus Mayer > --- > drivers/mfd/Kconfig | 8 ++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/bcm590xx.h | 31 +++++++++++++++ > 4 files changed, 133 insertions(+) > create mode 100644 drivers/mfd/bcm590xx.c > create mode 100644 include/linux/mfd/bcm590xx.h I have a tiny nit that 'ret' doesn't need to be initialised before use in probe(), but apart from that... Looks pretty sensible: Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog