Re: [PATCH] Port ofono test scripts to also work with Python3

[Martin Pitt <martin.pitt@ubuntu.com>]

[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]

Hey Denis,

Denis Kenzior [2014-03-11 10:33 -0500]:
> Could you submit these patches using git-send-email?  It would be
> way easier for me to reply with my comments.

Done now. First time I use it, I hope I didn't mess up anything.

> >>> print()
> ()
> >>>
> 
> This is probably not what you intended.

Indeed not, thanks for spotting. Changed to print('') now, which does
the same (and the right thing) with both Python 2 and 3. The new
git-send-email'ed patch already has this.

> Patches 2 and 3 seem to be just fine.  Couldn't apply because they
> depend on patch 1.

Yes, unfortunately they are quite intrusive :/

> >Patch 5 does the remaining bits (unicode and raw_input, and updating
> >hashbangs) and is currently *not* bilingual. If you want these scripts
> >to only work with Python 3 (which should be fine these days), it can
> >be applied (we already did that in the ofono-rilmodem branch[2]).
> >Otherwise, if you generally agree to doing this conversion I'm
> >happy to change it to a form where it works with both Python versions.
> >But that's more involved and it's work that I would only do after
> >getting your "yes, we'll take it" confirmation. :-)
> >
> 
> I'm okay moving to Python 3, but you might want to send this as an
> RFC to garner more feedback.

That patch is a lot smaller, so it can be applied independently of the
other four. What you mean with "send as RFC" other than sending it to
the ML for review?

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]