From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 1/5] bug: When !CONFIG_BUG, simplify WARN_ON_ONCE and family Date: Tue, 11 Mar 2014 17:40:25 +0100 Message-ID: <201403111740.25606.arnd@arndb.de> References: <469b5dc113cb468232291527642f8dc47663e945.1393385236.git.josh@joshtriplett.org> <6915585.VegnvotSUi@wuerfel> <17c859aa7dcccec43df0a0c8908911b982764c76.1394412745.git.josh@joshtriplett.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.126.130]:58720 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945AbaCKQk0 (ORCPT ); Tue, 11 Mar 2014 12:40:26 -0400 In-Reply-To: <17c859aa7dcccec43df0a0c8908911b982764c76.1394412745.git.josh@joshtriplett.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Josh Triplett Cc: Andrew Morton , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Monday 10 March 2014, Josh Triplett wrote: > > When !CONFIG_BUG, WARN_ON and family become simple passthroughs of their > condition argument; however, WARN_ON_ONCE and family still have > conditions and a boolean to detect one-time invocation, even though the > warning they'd emit doesn't exist. Make the existing definitions > conditional on CONFIG_BUG, and add definitions for !CONFIG_BUG that map > to the passthrough versions of WARN and WARN_ON. > > This saves 4.4k on a minimized configuration (smaller than > allnoconfig), and 20.6k with defconfig plus CONFIG_BUG=n. > > Signed-off-by: Josh Triplett > --- > v3: Patch unchanged from v2. > > Andrew, can you please replace the entire v2 series currently in -mm > with this new series? [all patches] Acked-by: Arnd Bergmann