From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from quartz.orcorp.ca ([184.70.90.242]:51100 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbaCKVpg (ORCPT ); Tue, 11 Mar 2014 17:45:36 -0400 Date: Tue, 11 Mar 2014 15:45:25 -0600 From: Jason Gunthorpe To: Ezequiel Garcia Cc: Wim Van Sebroeck , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Petazzoni , Lior Amsalem , Tawfik Bayouk , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 0/7] Watchdog support for Armada 375/38x SoC Message-ID: <20140311214525.GA3564@obsidianresearch.com> References: <1393949244-5011-1-git-send-email-ezequiel.garcia@free-electrons.com> <20140307001346.GB13690@arch.cereza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140307001346.GB13690@arch.cereza> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Thu, Mar 06, 2014 at 09:13:46PM -0300, Ezequiel Garcia wrote: > > On the driver side, we need to implement per-SoC stop() and enabled() > > functions. Such somewhat complex infrastructure is needed to ensure the driver > > performs proper reset of the watchdog timer, by masking and disabling the > > RSTOUT before the interrupt is enabled. > JasonG: How does this look now? A cursory look seems reasonable.. > Any chance someone gives a Tested-by on Dove/Kirkwood? If you have a git I can pull I can try it here. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 0/7] Watchdog support for Armada 375/38x SoC Date: Tue, 11 Mar 2014 15:45:25 -0600 Message-ID: <20140311214525.GA3564@obsidianresearch.com> References: <1393949244-5011-1-git-send-email-ezequiel.garcia@free-electrons.com> <20140307001346.GB13690@arch.cereza> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140307001346.GB13690-nAQHv47ARr+vIlHkl8J1cg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ezequiel Garcia Cc: Wim Van Sebroeck , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Petazzoni , Lior Amsalem , Tawfik Bayouk , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Mar 06, 2014 at 09:13:46PM -0300, Ezequiel Garcia wrote: > > On the driver side, we need to implement per-SoC stop() and enabled() > > functions. Such somewhat complex infrastructure is needed to ensure the driver > > performs proper reset of the watchdog timer, by masking and disabling the > > RSTOUT before the interrupt is enabled. > JasonG: How does this look now? A cursory look seems reasonable.. > Any chance someone gives a Tested-by on Dove/Kirkwood? If you have a git I can pull I can try it here. Jason -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html