All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_db: hide debug bbmap output
Date: Wed, 12 Mar 2014 09:51:43 +1100	[thread overview]
Message-ID: <20140311225142.GC6851@dastard> (raw)
In-Reply-To: <531F33F4.40707@sandeen.net>

On Tue, Mar 11, 2014 at 11:04:04AM -0500, Eric Sandeen wrote:
> Most of xfsprogs building with DEBUG enables extra
> checks, asserts, etc, but this bunch of printfs was
> extra output that's not generally helpful for most
> people's runtime experience - and it breaks xfs/290
> with all the noise.
> 
> I assume it's for actual debugging use, and not
> generally useful, so bury it a bit deeper under
> it's own #ifdef.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Just remove it, I think. It doesn't serve any real purpose anymore,
and changing it to an obscure ifdef guarantees it'll never get used
again...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2014-03-11 22:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 16:04 [PATCH] xfs_db: hide debug bbmap output Eric Sandeen
2014-03-11 22:51 ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311225142.GC6851@dastard \
    --to=david@fromorbit.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.