From: Frederic Weisbecker <fweisbec@gmail.com>
To: Rik van Riel <riel@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/6] cputime: Fix nsecs_to_cputime() return type cast
Date: Wed, 12 Mar 2014 03:14:56 +0100 [thread overview]
Message-ID: <20140312021453.GA26283@localhost.localdomain> (raw)
In-Reply-To: <5318C50D.2010505@redhat.com>
On Thu, Mar 06, 2014 at 01:57:17PM -0500, Rik van Riel wrote:
> On 03/06/2014 12:56 PM, Frederic Weisbecker wrote:
> >Even though nsec based cputime_t maps to u64, nsecs_to_cputime() must
> >return a cputime_t value. We want to enforce this kind of cast in order
> >to track down buggy manipulations of cputime_t such as direct access
> >of its values under wrong assumptions on its backend type (nsecs,
> >jiffies, etc...) by core code.
> >
> >Cc: Ingo Molnar <mingo@kernel.org>
> >Cc: Marcelo Tosatti <mtosatti@redhat.com>
> >Cc: Peter Zijlstra <peterz@infradead.org>
> >Cc: Thomas Gleixner <tglx@linutronix.de>
> >Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
>
> Acked-by: Rik van Riel <riel@redhat.com>
>
Thanks a lot for your acks. I added them for the pull request.
Unfortunately git-send-email ignored them for the Cc (it seems to
depend on the version).
But the pull request can be found there: http://marc.info/?i=1394590202-772-1-git-send-email-fweisbec%40gmail.com
next prev parent reply other threads:[~2014-03-12 2:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 17:56 [PATCH 0/6] cputime: Fixes and cleanups on steal time accounting Frederic Weisbecker
2014-03-06 17:56 ` [PATCH 1/6] cputime: Fix nsecs_to_cputime() return type cast Frederic Weisbecker
2014-03-06 18:57 ` Rik van Riel
2014-03-12 2:14 ` Frederic Weisbecker [this message]
2014-03-06 17:56 ` [PATCH 2/6] cputime: Default implementation of nsecs -> cputime conversion Frederic Weisbecker
2014-03-06 19:17 ` Rik van Riel
2014-03-06 17:56 ` [PATCH 3/6] cputime: Bring cputime -> nsecs conversion Frederic Weisbecker
2014-03-06 19:24 ` Rik van Riel
2014-03-06 17:56 ` [PATCH 4/6] cputime: Fix jiffies based cputime assumption on steal accounting Frederic Weisbecker
2014-03-06 19:36 ` Rik van Riel
2014-03-06 17:56 ` [RFC PATCH 5/6] sched: Remove needless round trip nsecs <-> tick conversion of steal time Frederic Weisbecker
2014-03-06 19:39 ` Rik van Riel
2014-03-06 17:56 ` [PATCH 6/6] arch: Remove stub cputime.h headers Frederic Weisbecker
2014-03-06 19:40 ` Rik van Riel
-- strict thread matches above, loose matches on Subject: below --
2014-03-12 2:09 [GIT PULL] timers updates for 3.15 Frederic Weisbecker
2014-03-12 2:09 ` [PATCH 1/6] cputime: Fix nsecs_to_cputime() return type cast Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312021453.GA26283@localhost.localdomain \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.