From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
sfr@canb.auug.org.au, hpa@zytor.com
Subject: Re: [PATCH v2] perf/x86/uncore: fix compilation warning in snb_uncore_imc_init_box()
Date: Wed, 12 Mar 2014 08:05:23 +0100 [thread overview]
Message-ID: <20140312070523.GL30956@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140311235329.GA28624@quad>
On Wed, Mar 12, 2014 at 12:53:30AM +0100, Stephane Eranian wrote:
> #ifdef CONFIG_PHYS_ADDR_T_64BIT
> - pci_read_config_dword(pdev, SNB_UNCORE_PCI_IMC_BAR_OFFSET+4, &addr_hi);
> - addr = ((resource_size_t)addr_hi << 32) | addr_lo;
> + pci_read_config_dword(pdev, where + 4, &pci_dword);
> + addr |= ((resource_size_t)pci_dword << 32);
> #endif
Indent fail there; fixed it.
FWIW; I thought of an even more horrible solution:
resource_size_t addr;
u32 *addr_ptr = &addr;
pci_read_config_dword(pdev, SNB_UNCORE_PCI_IMC_BAR_OFFSET, &addr_ptr[0]);
#ifdef ..
pci_read_config_dword(pdev, SNB_UNCORE_PCI_IMC_BAR_OFFSET+4, &addr_ptr[1]);
#endif
:-)
next prev parent reply other threads:[~2014-03-12 7:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 23:53 [PATCH v2] perf/x86/uncore: fix compilation warning in snb_uncore_imc_init_box() Stephane Eranian
2014-03-12 7:05 ` Peter Zijlstra [this message]
2014-03-12 9:23 ` Stephane Eranian
2014-03-12 10:10 ` [tip:perf/core] perf/x86/uncore: Fix " tip-bot for Stephane Eranian
2014-04-15 20:35 ` [PATCH v2] perf/x86/uncore: fix " Kirill A. Shutemov
2014-04-16 15:10 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312070523.GL30956@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.