All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: "Jakub Kiciński" <moorray3@wp.pl>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, <netdev@vger.kernel.org>,
	Fan Du <fan.du@windriver.com>
Subject: Re: net-next: NULL pointer dereference on adding a net namespace and a system freeze
Date: Wed, 12 Mar 2014 09:38:27 +0100	[thread overview]
Message-ID: <20140312083827.GE32371@secunet.com> (raw)
In-Reply-To: <20140311153029.1de9d6e9@north>

On Tue, Mar 11, 2014 at 03:30:29PM +0100, Jakub Kiciński wrote:
> 
> Tested with del_timer_sync and unregister_hotcpu_notifier:
> 
> void flow_cache_fini(struct net *net)
> {
> 	int i;
> 	struct flow_cache *fc = &net->xfrm.flow_cache_global;
> 
> 	unregister_hotcpu_notifier(&fc->hotcpu_notifier);
> 	del_timer_sync(&fc->rnd_timer);
> 
> 	for_each_possible_cpu(i) {
> 		struct flow_cache_percpu *fcp = per_cpu_ptr(fc->percpu, i);
> 		kfree(fcp->hash_table);
> 		fcp->hash_table = NULL;
> 	}
> 
> 	free_percpu(fc->percpu);
> 	fc->percpu = NULL;
> }
> EXPORT_SYMBOL(flow_cache_fini);
> 
> 
> Seems to solve both the freeze and the bug on restarting libvirtd/rtkit!
> 

Thanks a lot for testing!

I'll submit the updated patch now.

  reply	other threads:[~2014-03-12  8:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  0:44 net-next: NULL pointer dereference on adding a net namespace and a system freeze Jakub Kicinski
2014-03-10  4:02 ` Eric Dumazet
2014-03-10  4:09   ` Eric Dumazet
2014-03-10  6:51     ` Fan Du
2014-03-10 13:44       ` Eric Dumazet
2014-03-10 14:09         ` [PATCH net-next] flowcache: restore a single flow_cache kmem_cache Eric Dumazet
2014-03-11  1:45           ` David Miller
2014-03-10 12:19     ` net-next: NULL pointer dereference on adding a net namespace and a system freeze Jakub Kiciński
2014-03-10 14:04       ` Eric Dumazet
2014-03-11  0:46         ` Jakub Kiciński
2014-03-11  5:30           ` Steffen Klassert
2014-03-11 12:00           ` Steffen Klassert
2014-03-11 12:40             ` Eric Dumazet
2014-03-11 13:20               ` Steffen Klassert
2014-03-11 14:30                 ` Jakub Kiciński
2014-03-12  8:38                   ` Steffen Klassert [this message]
2014-03-12  8:43                     ` [PATCH net-next] flowcache: Fix resource leaks on namespace exit Steffen Klassert
2014-03-12 11:43                       ` Eric Dumazet
2014-03-12 19:31                       ` David Miller
2014-03-11 12:42             ` net-next: NULL pointer dereference on adding a net namespace and a system freeze Jakub Kiciński
2014-03-12 10:02             ` Fan Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140312083827.GE32371@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=eric.dumazet@gmail.com \
    --cc=fan.du@windriver.com \
    --cc=moorray3@wp.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.