From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Benoît Canet" <benoit.canet@irqsave.net>,
qemu-devel@nongnu.org, stefanha@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache()
Date: Wed, 12 Mar 2014 10:43:30 +0100 [thread overview]
Message-ID: <20140312094330.GA3245@irqsave.net> (raw)
In-Reply-To: <20140312094000.GA2662@dhcp-200-207.str.redhat.com>
The Wednesday 12 Mar 2014 à 10:40:00 (+0100), Kevin Wolf wrote :
> Am 11.03.2014 um 17:41 hat Benoît Canet geschrieben:
> > I have the impression that you are silently fixing other nits;
>
> Am I?
>
> Not intentionally at least. I think I can justify every single line of
> the patch with respect to the bug described in the commit message. We
> need to recursive into the protocol layer, and we need to refresh
> bs->total_sectors. For drivers implementing the callback, we need to
> recurse to bs->file between the internal open/close pair.
>
> I can't see what could be left out in this patch.
I didn't understood the implication on recursion at first sight.
Best regards
Benoît
>
> Kevin
>
prev parent reply other threads:[~2014-03-12 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 9:58 [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache() Kevin Wolf
2014-03-11 11:36 ` Juan Quintela
2014-03-11 12:47 ` Stefan Hajnoczi
2014-03-11 16:41 ` Benoît Canet
2014-03-12 9:40 ` Kevin Wolf
2014-03-12 9:43 ` Benoît Canet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312094330.GA3245@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.