From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jiri Popelka <jpopelka@redhat.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: make 'iptables-save -M' actually work
Date: Wed, 12 Mar 2014 14:50:38 +0100 [thread overview]
Message-ID: <20140312135038.GA31353@localhost> (raw)
In-Reply-To: <1394630169-21124-1-git-send-email-jpopelka@redhat.com>
On Wed, Mar 12, 2014 at 02:16:09PM +0100, Jiri Popelka wrote:
> also add missing bracket in iptables-save(8)
Please, put this in a separated patch.
Could you also fix this in the nftables compat layer, please? See
iptables/xtables-save.c.
Most likely you'll need to define a struct xtables_afinfo for IPv4 and
IPv6 to set the .kmod field that points to nf_tables_ipv4 and
nf_tables_ipv6 respectively. Similar to what we use in
xtables-arp-standalone.c, and skip xtables_set_nfproto of course. This
is currently broken there.
Thanks.
next prev parent reply other threads:[~2014-03-12 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 13:16 [PATCH] iptables: make 'iptables-save -M' actually work Jiri Popelka
2014-03-12 13:50 ` Pablo Neira Ayuso [this message]
2014-03-13 16:05 ` Jiri Popelka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312135038.GA31353@localhost \
--to=pablo@netfilter.org \
--cc=jpopelka@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.