From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [RFCv2 05/10] drm: Add plane type property
Date: Wed, 12 Mar 2014 09:43:11 -0700
Message-ID: <20140312164311.GG6117@intel.com>
References: <1394237002-18041-1-git-send-email-matthew.d.roper@intel.com>
	<1394237002-18041-6-git-send-email-matthew.d.roper@intel.com>
	<20140311164500.16e2316b@bpaauwe-desk.fm.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id C9E04FB194
	for <dri-devel@lists.freedesktop.org>;
	Wed, 12 Mar 2014 09:43:53 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140311164500.16e2316b@bpaauwe-desk.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Bob Paauwe <bob.j.paauwe@intel.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Tue, Mar 11, 2014 at 04:45:00PM -0700, Bob Paauwe wrote:
> On Fri, 7 Mar 2014 16:03:17 -0800
> Matt Roper <matthew.d.roper@intel.com> wrote:
...
> > +static int drm_mode_create_standard_plane_properties(struct drm_device *dev)
> > +{
> > +	struct drm_property *type;
> > +
> > +	/*
> > +	 * Standard properties (apply to all planes)
> > +	 */
> > +	type = drm_property_create_enum(dev, 0,
> > +					"TYPE", drm_plane_type_enum_list,
> > +					ARRAY_SIZE(drm_plane_type_enum_list));
> 
> Should this property be created with DRM_MODE_PROP_IMMUTABLE set?  What
> happens if user space tries to change this property to a different type?
> 

Yep, good point.  I'll add that flag in my next revision of the
patchset.

Thanks!


Matt

-- 
Matt Roper
Graphics Software Engineer
ISG Platform Enabling & Development
Intel Corporation
(916) 356-2795