From: Rakesh Pandit <rakesh@tuxera.com>
To: <dsterba@suse.cz>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs-progs: mkfs: let user known when forcing mixed metadata/data groups
Date: Wed, 12 Mar 2014 18:59:35 +0200 [thread overview]
Message-ID: <20140312165935.GA1557@localhost.localdomain> (raw)
In-Reply-To: <20140312163614.GC6782@twin.jikos.cz>
On Wed, Mar 12, 2014 at 05:36:14PM +0100, David Sterba wrote:
> On Wed, Mar 12, 2014 at 03:43:24PM +0200, Rakesh Pandit wrote:
> > While formatting multiple devics (and user doesn't specify -M) if one
> > of them has block count or size less then 1 GiB, mkfs doesn't tell
> > user, on which one mixed metadata/data was forced. This patch updates
> > message to print device name.
>
> I think we should fix the constraints what devices can be used together,
> mixing small and large ones works, but I don't think it's the usecase
> I'd recommend. And I'm not sure the mixed profile was intended for
> multiple devices at all.
Yes makes sense, thanks for review.
regards,
prev parent reply other threads:[~2014-03-12 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 13:43 [PATCH] Btrfs-progs: mkfs: let user known when forcing mixed metadata/data groups Rakesh Pandit
2014-03-12 16:36 ` David Sterba
2014-03-12 16:59 ` Rakesh Pandit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312165935.GA1557@localhost.localdomain \
--to=rakesh@tuxera.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.