All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: fstrim has no effect on a just-mounted filesystem
Date: Wed, 12 Mar 2014 18:24:16 +0000	[thread overview]
Message-ID: <20140312182416.GB1346@redhat.com> (raw)
In-Reply-To: <5320A322.7020009@redhat.com>

On Wed, Mar 12, 2014 at 07:10:42PM +0100, Paolo Bonzini wrote:
> Il 12/03/2014 11:17, Richard W.M. Jones ha scritto:
> >Somewhere, the discard requests are disappearing in the stack (or more
> >likely, being delayed).  blktrace/trace-cmd somehow forces them out.
> >But fsync/sync/umount/sleep does not.  They might be stuck in qemu too ...
> 
> No, this I can be quite sure about.  QEMU sends them as soon as they
> are received in the SCSI layer.  If they were ill-formed, QEMU would
> fail them.  If they got stuck, sooner or later you'd not be able to
> do I/O anymore (there is a queue depth limit) and the guest would
> start getting timeouts.
> 
> Also, certainly blktrace would have no effect on QEMU.

Yup, it was completely a bug at my end.  Now that is fixed,
fstrim works perfectly.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)

      reply	other threads:[~2014-03-12 18:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 21:39 fstrim has no effect on a just-mounted filesystem Richard W.M. Jones
2014-03-11 21:47 ` Eric Sandeen
2014-03-11 22:00   ` Richard W.M. Jones
2014-03-11 22:04     ` Richard W.M. Jones
2014-03-11 22:08     ` Eric Sandeen
2014-03-11 22:59       ` Richard W.M. Jones
2014-03-11 23:07         ` Richard W.M. Jones
2014-03-11 23:09           ` Eric Sandeen
2014-03-11 23:30             ` Richard W.M. Jones
2014-03-12 10:17               ` Richard W.M. Jones
2014-03-12 13:42                 ` Richard W.M. Jones
2014-03-12 18:10                 ` Paolo Bonzini
2014-03-12 18:24                   ` Richard W.M. Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140312182416.GB1346@redhat.com \
    --to=rjones@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.