From: Dave Jones <davej@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
x86@kernel.org, Stefani Seibold <stefani@seibold.net>,
Andreas Brief <Andreas.Brief@rohde-schwarz.com>,
Martin Runge <Martin.Runge@rohde-schwarz.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH v2 2/2] x86_32: Remove user bit from identity map PDE
Date: Wed, 12 Mar 2014 14:39:25 -0400 [thread overview]
Message-ID: <20140312183925.GA19927@redhat.com> (raw)
In-Reply-To: <6a0db396c4b00ab6fee0d091039b549dd761e9b3.1394648864.git.luto@amacapital.net>
On Wed, Mar 12, 2014 at 11:29:45AM -0700, Andy Lutomirski wrote:
> The only reason that the user bit was set was to support userspace
> access to the compat vDSO in the fixmap. The compat vDSO is gone,
> so the user bit can be removed.
>
> -/*
> - * For PDE_IDENT_ATTR include USER bit. As the PDE and PTE protection
> - * bits are combined, this will alow user to access the high address mapped
> - * VDSO in the presence of CONFIG_COMPAT_VDSO
> - */
> #define PTE_IDENT_ATTR 0x003 /* PRESENT+RW */
> -#define PDE_IDENT_ATTR 0x067 /* PRESENT+RW+USER+DIRTY+ACCESSED */
> +#define PDE_IDENT_ATTR 0x063 /* PRESENT+RW+USER+DIRTY+ACCESSED */
> #define PGD_IDENT_ATTR 0x001 /* PRESENT (no other attributes) */
update the comment too ?
Dave
next prev parent reply other threads:[~2014-03-12 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 18:29 [PATCH v2 0/2] x86: Remove compat vdso support Andy Lutomirski
2014-03-12 18:29 ` [PATCH v2 1/2] " Andy Lutomirski
2014-03-12 18:29 ` [PATCH v2 2/2] x86_32: Remove user bit from identity map PDE Andy Lutomirski
2014-03-12 18:39 ` Dave Jones [this message]
2014-03-12 18:52 ` Andy Lutomirski
-- strict thread matches above, loose matches on Subject: below --
2014-03-11 22:15 [PATCH v2 0/2] x86: Relocate the compat vdso per process Andy Lutomirski
2014-03-11 22:15 ` [PATCH v2 2/2] x86_32: Remove user bit from identity map PDE Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312183925.GA19927@redhat.com \
--to=davej@redhat.com \
--cc=Andreas.Brief@rohde-schwarz.com \
--cc=Martin.Runge@rohde-schwarz.com \
--cc=andi@firstfloor.org \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=stefani@seibold.net \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.