From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 12 Mar 2014 15:35:04 -0400 Subject: [U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM In-Reply-To: <5320B3B6.4050704@ti.com> References: <1392918914-15564-1-git-send-email-m-karicheri2@ti.com> <20140225221046.GC16805@bill-the-cat> <5320B3B6.4050704@ti.com> Message-ID: <20140312193504.GX16805@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Mar 12, 2014 at 03:21:26PM -0400, Murali Karicheri wrote: > On 2/25/2014 5:10 PM, Rini, Tom wrote: > >On Thu, Feb 20, 2014 at 12:55:02PM -0500, Murali Karicheri wrote: > > > >>This patch series add support for keystone2 SoC and K2HK EVM > >In general, you ran checkpatch.pl right? I see some '#define' > >cases that need manual fixing up as well. Further comments and acks > >coming. > > > Tom, > > Just want to check with you what you want me to fix for #define > . Generally from > my Linux experience, I have seen #define used with tab. I looked at > few header files and > that have this tab in #define. So where this restriction come from? > I looked into the > Documentation/CodingStyle in Linux source tree and can't find any > rule of not to > use #define . It's a thing here at least that yes, '#define' only, and we do have a few things that need cleaning up. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: