From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v3] xfstests: shared/051: add filter to match the golden output for large acls
Date: Thu, 13 Mar 2014 14:08:34 +1100 [thread overview]
Message-ID: <20140313030834.GB4263@dastard> (raw)
In-Reply-To: <5320FE44.8050000@oracle.com>
On Thu, Mar 13, 2014 at 08:39:32AM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> On old kernel we return EINVAL if hit the limits of maximum number of
> ACLs but return E2BIG on new kernel, which cause the test failes on new
> kernel as the output is mismatch to the goldens. This patch fix it by
> updating the golden output with the new error message and replacing the
> old error message with it via a filter.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
>
> V3->V2: filter out the old error message to the new and update golden output to match it
> V2->V1: filter out the new error message to the old
Looks good
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-03-13 3:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 0:39 [PATCH v3] xfstests: shared/051: add filter to match the golden output for large acls Jeff Liu
2014-03-13 3:08 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313030834.GB4263@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.