From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Lucas Nussbaum <lucas.nussbaum@loria.fr>,
linux-ext4@vger.kernel.org,
"linux-fsdevel@vger.kernel.org Emmanuel Jeanvoine"
<emmanuel.jeanvoine@inria.fr>
Subject: Re: [PATCH, RFC] fs: only call sync_filesystem() when remounting read-only
Date: Thu, 13 Mar 2014 00:39:36 -0700 [thread overview]
Message-ID: <20140313073936.GA14663@infradead.org> (raw)
In-Reply-To: <20140313003635.GA4263@dastard>
On Thu, Mar 13, 2014 at 11:36:35AM +1100, Dave Chinner wrote:
> IMO, I think that you should be looking to fix ext4 syncfs issues,
> not changing the VFS behaviour that might cause subtle and unnoticed
> problems for other filesystems. We should not be moving data
> inegrity operations without first auditing of all the filesystem
> remount operations for issues.
Requiring a sync on every remount that doesn't go read-only seems odd
to me, so removing it doesn't sound bad. However I agree that a proper
audit of filesystems should be done, e.g.:
patch 1:
move calls into the filesystems, explaining why filesystems not
implementing ->remount_fs should be safe
patch 2:
remove call from ext4, safe because of $FOO
patch b:
remove call from $fs, safe because of $BAR
next prev parent reply other threads:[~2014-03-13 7:39 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 14:13 Extremely slow remounts with concurrent I/O Lucas Nussbaum
2014-03-06 13:56 ` [PATCH, RFC] jbd2: don't write non-commit blocks synchronously Theodore Ts'o
2014-03-06 17:28 ` Lucas Nussbaum
2014-03-06 18:27 ` Theodore Ts'o
2014-03-06 18:45 ` Lucas Nussbaum
2014-03-06 18:37 ` Lucas Nussbaum
2014-03-08 16:08 ` [PATCH, RFC] fs: only call sync_filesystem() when remounting read-only Theodore Ts'o
2014-03-08 16:08 ` Theodore Ts'o
2014-03-10 11:45 ` Lucas Nussbaum
2014-03-10 14:41 ` Theodore Ts'o
2014-03-10 12:15 ` Lucas Nussbaum
2014-03-13 0:36 ` Dave Chinner
2014-03-13 1:16 ` Theodore Ts'o
2014-03-13 3:14 ` Theodore Ts'o
2014-03-13 6:04 ` Dave Chinner
2014-03-13 12:55 ` Theodore Ts'o
2014-03-13 7:39 ` Christoph Hellwig [this message]
2014-03-13 14:20 ` [Cluster-devel] [PATCH] fs: push sync_filesystem() down to the file system's remount_fs() Theodore Ts'o
2014-03-13 14:22 ` [Ocfs2-devel] " Theodore Ts'o
2014-03-13 14:20 ` Theodore Ts'o
2014-03-13 14:20 ` Theodore Ts'o
2014-03-13 14:20 ` Theodore Ts'o
2014-03-13 14:20 ` Theodore Ts'o
2014-03-13 14:50 ` Anders Larsen
2014-03-13 16:23 ` [Cluster-devel] " Jan Kara
2014-03-13 16:23 ` [Ocfs2-devel] " Jan Kara
2014-03-13 16:23 ` Jan Kara
2014-03-13 16:23 ` Jan Kara
2014-03-13 16:23 ` Jan Kara
2014-03-13 16:23 ` Jan Kara
2014-03-13 16:28 ` [Cluster-devel] " Steven Whitehouse
2014-03-13 16:28 ` [Ocfs2-devel] " Steven Whitehouse
2014-03-13 16:28 ` Steven Whitehouse
2014-03-13 16:28 ` Steven Whitehouse
2014-03-13 16:28 ` Steven Whitehouse
2014-03-13 16:28 ` Steven Whitehouse
2014-03-13 16:28 ` [Cluster-devel] " Steven Whitehouse
2014-03-13 16:28 ` Steven Whitehouse
2014-03-13 23:15 ` [Cluster-devel] " Theodore Ts'o
2014-03-13 23:15 ` [Ocfs2-devel] " Theodore Ts'o
2014-03-13 23:15 ` Theodore Ts'o
2014-03-13 23:15 ` Theodore Ts'o
2014-03-13 23:15 ` Theodore Ts'o
2014-03-13 23:15 ` Theodore Ts'o
2014-03-14 12:13 ` Jan Kara
2014-03-14 12:13 ` [Ocfs2-devel] " Jan Kara
2014-03-14 12:13 ` Jan Kara
2014-03-14 12:13 ` Jan Kara
2014-03-14 12:13 ` Jan Kara
2014-03-14 12:13 ` Jan Kara
2014-03-14 0:33 ` Steve French
2014-03-14 0:33 ` [Ocfs2-devel] " Steve French
2014-03-14 0:33 ` Steve French
2014-03-14 0:33 ` Steve French
2014-03-14 0:33 ` Steve French
2014-03-14 0:33 ` Steve French
2014-03-14 1:23 ` [Cluster-devel] " Theodore Ts'o
2014-03-14 1:23 ` [Ocfs2-devel] " Theodore Ts'o
2014-03-14 1:23 ` Theodore Ts'o
2014-03-14 1:23 ` Theodore Ts'o
2014-03-14 1:23 ` Theodore Ts'o
2014-03-14 1:23 ` Theodore Ts'o
2014-03-13 7:19 ` Extremely slow remounts with concurrent I/O Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313073936.GA14663@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=emmanuel.jeanvoine@inria.fr \
--cc=linux-ext4@vger.kernel.org \
--cc=lucas.nussbaum@loria.fr \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.