Re: [Qemu-devel] [PATCH v2 4/9] block: Introduce bdrv_dirty_bitmap_granularity()

["Benoît Canet" <benoit.canet@irqsave.net>]

The Wednesday 12 Mar 2014 à 14:30:59 (+0800), Fam Zheng wrote :
> This returns the granularity (in sectors) of dirty bitmap.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block.c               | 6 ++++++
>  include/block/block.h | 2 ++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/block.c b/block.c
> index 9de1385..26a43eb 100644
> --- a/block.c
> +++ b/block.c
> @@ -5143,6 +5143,12 @@ int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, int64_t sector
>      }
>  }
>  
> +int bdrv_dirty_bitmap_granularity(BlockDriverState *bs,
> +                                  BdrvDirtyBitmap *bitmap)
> +{
> +    return hbitmap_granularity(bitmap->bitmap);
> +}
> +
>  void bdrv_dirty_iter_init(BlockDriverState *bs,
>                            BdrvDirtyBitmap *bitmap, HBitmapIter *hbi)
>  {
> diff --git a/include/block/block.h b/include/block/block.h
> index aa0c5e4..b87c071 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -446,6 +446,8 @@ BdrvDirtyBitmap *bdrv_find_dirty_bitmap(BlockDriverState *bs,
>  void bdrv_dirty_bitmap_make_anon(BlockDriverState *bs, BdrvDirtyBitmap *bitmap);
>  void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap);
>  BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs);
> +int bdrv_dirty_bitmap_granularity(BlockDriverState *bs,
> +                                  BdrvDirtyBitmap *bitmap);
>  int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, int64_t sector);
>  void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, int nr_sectors);
>  void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector, int nr_sectors);
> -- 
> 1.9.0
> 
> 
Reviewed-by: Benoit Canet <benoit@irqsave.net>