From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
Cc: Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: sh-sci: Prevent NULL pointer dereference
Date: Thu, 13 Mar 2014 13:40:21 +0000 [thread overview]
Message-ID: <20140313134021.GS366@sirena.org.uk> (raw)
In-Reply-To: <1394677957.15733.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
On Thu, Mar 13, 2014 at 10:32:37AM +0800, Axel Lin wrote:
> If sp->info is NULL, we will hit NULL pointer dereference in probe() while
> setting bus_num and num_chipselect for master:
>
> sp->bitbang.master->bus_num = sp->info->bus_num;
> sp->bitbang.master->num_chipselect = sp->info->num_chipselect;
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-03-13 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 2:32 [PATCH] spi: sh-sci: Prevent NULL pointer dereference Axel Lin
2014-03-13 9:52 ` Geert Uytterhoeven
2014-03-13 13:40 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313134021.GS366@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.