From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO80g-00061v-HS for qemu-devel@nongnu.org; Thu, 13 Mar 2014 11:57:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WO80Z-0003GP-FV for qemu-devel@nongnu.org; Thu, 13 Mar 2014 11:57:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO80Z-0003G5-7a for qemu-devel@nongnu.org; Thu, 13 Mar 2014 11:57:23 -0400 Date: Thu, 13 Mar 2014 15:57:11 +0000 From: "Richard W.M. Jones" Message-ID: <20140313155711.GE1346@redhat.com> References: <1394725871-21004-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1394725871-21004-1-git-send-email-afaerber@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next] virtio-console-test: Test virtserialport as well List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qemu-devel@nongnu.org On Thu, Mar 13, 2014 at 04:51:10PM +0100, Andreas F=E4rber wrote: > A test is only as good as its coverage - testing virtserialport in > addition to virtconsole shows that commit > 0399a3819b27083ba69b88a9baa9025facab85bd (virtio-console: QOM cast > cleanup for VirtConsole) broke virtserialport. This patch demonstrates the error for me when I use 'make check' in qemu.git, so ACK. Rich. --=20 Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rj= ones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top