From: "Richard W.M. Jones" <rjones@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Amit Shah <amit.shah@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH qom-next] virtio-console: Fix VIRTIO_CONSOLE() cast macro
Date: Thu, 13 Mar 2014 16:27:50 +0000 [thread overview]
Message-ID: <20140313162750.GF1346@redhat.com> (raw)
In-Reply-To: <1394727876-23310-1-git-send-email-afaerber@suse.de>
On Thu, Mar 13, 2014 at 05:24:36PM +0100, Andreas Färber wrote:
> Commit 0399a3819b27083ba69b88a9baa9025facab85bd (virtio-console: QOM
> cast cleanup for VirtConsole) broke virtserialport since it shares
> functions and state struct with virtconsole. Let virtconsole inherit
> from virtserialport, and use virtserialport type for casting.
>
> Note that virtio-serial-port is the abstract base type in
> virtio-serial-bus.c, whereas virtserialport is the user-instantiatable
> type in virtio-console.c. Therefore using TYPE_VIRTIO_CONSOLE_SERIAL_PORT.
>
> Reported-by: Richard W.M. Jones <rjones@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
This patch fixes the problem for me, thanks.
ACK.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
prev parent reply other threads:[~2014-03-13 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 16:24 [Qemu-devel] [PATCH qom-next] virtio-console: Fix VIRTIO_CONSOLE() cast macro Andreas Färber
2014-03-13 16:27 ` Richard W.M. Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313162750.GF1346@redhat.com \
--to=rjones@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.