From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] tools/libxc: fix errno handling for HVM in
	xc_domain_save
Date: Thu, 13 Mar 2014 18:57:35 +0100
Message-ID: <20140313175735.GA16807@aepfle.de>
References: <1394732071-14342-1-git-send-email-olaf@aepfle.de>
	<21281.61583.727192.311217@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <21281.61583.727192.311217@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian.Campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, Mar 13, Ian Jackson wrote:

> Olaf Hering writes ("[PATCH] tools/libxc: fix errno handling for HVM in xc_domain_save"):
> > The previous patch ("tools/libxc: pass errno to callers of
> > xc_domain_save") did not jump to the proper label if the domU is HVM.
> > 
> > Also make it clearer what "out" and "out_rc" are supposed to mean:
> > label "out" is for failure case, it expects errno to be set.
> > label "out_rc" is for success case, it preserves the initial errno for
> > the caller.
> 
> I agree with Ian that this is very confusing.  How about this instead ?

That would fix the current bug, yes.

Olaf