From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 13 Mar 2014 17:04:10 -0300 From: Ezequiel Garcia To: Sergei Shtylyov Subject: Re: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB Message-ID: <20140313200410.GA30590@arch.cereza> References: <1394739542-30017-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar> <53221AD4.3090002@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53221AD4.3090002@cogentembedded.com> Cc: Lior Amsalem , devicetree@vger.kernel.org, Mike Turquette , Jason Cooper , Tawfik Bayouk , Andrew Lunn , Seif Mazareeb , linux-mtd@lists.infradead.org, Ezequiel Garcia , Gregory Clement , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mar 13, Sergei Shtylyov wrote: > On 03/13/2014 10:39 PM, Ezequiel Garcia wrote: > > >From: Ezequiel Garcia > > >The Armada 385-DB board has a NAND flash, so enable it in the > >devicetree and add the partitions as prepared in the factory images. > > >Signed-off-by: Ezequiel Garcia > >--- > > arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > >diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts > >index 9a13642..edcf7ff 100644 > >--- a/arch/arm/boot/dts/armada-385-db.dts > >+++ b/arch/arm/boot/dts/armada-385-db.dts > >@@ -80,6 +80,27 @@ > > reg = <1>; > > }; > > }; > >+ > >+ flash: flash@d0000 { > > Note that you don't have to label your device the same way as it's named, > i.e. you could have labelled it "nand" if it would make things clearer. Right. > Although I don't readily see the value of labeling nodes in the board's > .dts file. Do you really expect to refer to it somewhere? > Yeah, I was thinking the same thing just after I sent this. No, I don't think we need the label. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Thu, 13 Mar 2014 17:04:10 -0300 Subject: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB In-Reply-To: <53221AD4.3090002@cogentembedded.com> References: <1394739542-30017-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar> <53221AD4.3090002@cogentembedded.com> Message-ID: <20140313200410.GA30590@arch.cereza> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mar 13, Sergei Shtylyov wrote: > On 03/13/2014 10:39 PM, Ezequiel Garcia wrote: > > >From: Ezequiel Garcia > > >The Armada 385-DB board has a NAND flash, so enable it in the > >devicetree and add the partitions as prepared in the factory images. > > >Signed-off-by: Ezequiel Garcia > >--- > > arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > >diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts > >index 9a13642..edcf7ff 100644 > >--- a/arch/arm/boot/dts/armada-385-db.dts > >+++ b/arch/arm/boot/dts/armada-385-db.dts > >@@ -80,6 +80,27 @@ > > reg = <1>; > > }; > > }; > >+ > >+ flash: flash at d0000 { > > Note that you don't have to label your device the same way as it's named, > i.e. you could have labelled it "nand" if it would make things clearer. Right. > Although I don't readily see the value of labeling nodes in the board's > .dts file. Do you really expect to refer to it somewhere? > Yeah, I was thinking the same thing just after I sent this. No, I don't think we need the label. -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB Date: Thu, 13 Mar 2014 17:04:10 -0300 Message-ID: <20140313200410.GA30590@arch.cereza> References: <1394739542-30017-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar> <53221AD4.3090002@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <53221AD4.3090002-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sergei Shtylyov Cc: Ezequiel Garcia , Mike Turquette , Jason Cooper , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lior Amsalem , Tawfik Bayouk , Seif Mazareeb , Thomas Petazzoni , Gregory Clement , Andrew Lunn , Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org On Mar 13, Sergei Shtylyov wrote: > On 03/13/2014 10:39 PM, Ezequiel Garcia wrote: >=20 > >From: Ezequiel Garcia >=20 > >The Armada 385-DB board has a NAND flash, so enable it in the > >devicetree and add the partitions as prepared in the factory images. >=20 > >Signed-off-by: Ezequiel Garcia > >--- > > arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) >=20 > >diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts= /armada-385-db.dts > >index 9a13642..edcf7ff 100644 > >--- a/arch/arm/boot/dts/armada-385-db.dts > >+++ b/arch/arm/boot/dts/armada-385-db.dts > >@@ -80,6 +80,27 @@ > > reg =3D <1>; > > }; > > }; > >+ > >+ flash: flash@d0000 { >=20 > Note that you don't have to label your device the same way as it's= named, > i.e. you could have labelled it "nand" if it would make things cleare= r. Right. > Although I don't readily see the value of labeling nodes in the bo= ard's > .dts file. Do you really expect to refer to it somewhere? >=20 Yeah, I was thinking the same thing just after I sent this. No, I don't= think we need the label. --=20 Ezequiel Garc=EDa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html