From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Alexandre Courbot <gnurou@gmail.com>,
Lan Tianyu <tianyu.lan@intel.com>, Lv Zheng <lv.zheng@intel.com>,
Alan Cox <alan.cox@intel.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] gpio / ACPI: Add support for ACPI GPIO operation regions
Date: Fri, 14 Mar 2014 13:11:51 +0200 [thread overview]
Message-ID: <20140314111151.GH5018@intel.com> (raw)
In-Reply-To: <CACRpkdZfeGkHp8kc-Uv+5Q6xRN1NwiZD-kLWS93x0jV=kn30MA@mail.gmail.com>
On Fri, Mar 14, 2014 at 11:53:30AM +0100, Linus Walleij wrote:
> On Thu, Mar 13, 2014 at 4:18 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Thu, Mar 13, 2014 at 03:32:01PM +0100, Linus Walleij wrote:
>
> >> > + case ACPI_IO_RESTRICT_OUTPUT:
> >> > + gpiod_direction_output(desc, pull);
> >>
> >> Can you explain why the fact that the line is pulled down affects the
> >> default output value like this? I don't get it.
> >
> > That's the thing - ACPI doesn't tell us what is the initial value of the
> > pin. There is no such field in GpioIo() resource.
> >
> > So I'm assuming here that if it says that the pin is pulled up, the default
> > value will be high.
>
> OK! So exactly that statement is what I want to see as a comment
> in this switch case.
Sure. I'll add that comment to the next version of this patch.
next prev parent reply other threads:[~2014-03-14 11:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 12:54 [PATCH v2 0/5] gpio / ACPI: Rework ACPI GPIO events and add support for operation regions Mika Westerberg
2014-03-10 12:54 ` [PATCH v2 1/5] gpiolib: Allow GPIO chips to request their own GPIOs Mika Westerberg
2014-03-13 4:46 ` Alexandre Courbot
2014-03-10 12:54 ` [PATCH v2 2/5] gpio / ACPI: Allocate ACPI specific data directly in acpi_gpiochip_add() Mika Westerberg
2014-03-10 12:54 ` [PATCH v2 3/5] gpio / ACPI: Rename acpi_gpio_evt_pin to acpi_gpio_event Mika Westerberg
2014-03-10 12:54 ` [PATCH v2 4/5] gpio / ACPI: Rework ACPI GPIO event handling Mika Westerberg
2014-03-10 12:54 ` [PATCH v2 5/5] gpio / ACPI: Add support for ACPI GPIO operation regions Mika Westerberg
2014-03-13 14:32 ` Linus Walleij
2014-03-13 15:05 ` Cox, Alan
2014-03-13 15:05 ` Cox, Alan
2014-03-14 10:50 ` Linus Walleij
2014-03-13 15:18 ` Mika Westerberg
2014-03-14 10:53 ` Linus Walleij
2014-03-14 11:11 ` Mika Westerberg [this message]
2014-03-14 15:58 ` [PATCH v3 " Mika Westerberg
2014-03-14 16:25 ` Linus Walleij
2014-03-17 9:44 ` Mika Westerberg
2014-03-13 14:17 ` [PATCH v2 0/5] gpio / ACPI: Rework ACPI GPIO events and add support for " Linus Walleij
2014-03-13 17:14 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314111151.GH5018@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=alan.cox@intel.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=tianyu.lan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.