From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
Mike Snitzer <snitzer@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Kernel bug triggered in multipath
Date: Fri, 14 Mar 2014 04:15:20 -0700 [thread overview]
Message-ID: <20140314111520.GA17288@infradead.org> (raw)
In-Reply-To: <1394795632-86434-1-git-send-email-hare@suse.de>
On Fri, Mar 14, 2014 at 12:13:52PM +0100, Hannes Reinecke wrote:
> Starting multipath on a cciss device will cause a kernel
> warning to be triggered. Problem is that we're using the
> ->queuedata field of the request_queue to derefence the
> scsi device; however, for other (non-SCSI) devices this
> points to a totally different structure.
> So we should rather be using accessors here which make
> sure we're only returning valid SCSI device structures.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Looks reasonable to me as a short term fix. Long ter mwe should stop
calling into scsi-specific code directly from the DM code.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2014-03-14 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 11:13 [PATCH] Kernel bug triggered in multipath Hannes Reinecke
2014-03-14 11:15 ` Christoph Hellwig [this message]
2014-03-14 16:21 ` Mike Snitzer
2014-03-14 16:26 ` Mike Snitzer
2014-03-15 13:23 ` Christoph Hellwig
2014-03-15 13:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314111520.GA17288@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.