* [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h
@ 2013-12-09 9:49 ` Qais Yousef
0 siblings, 0 replies; 6+ messages in thread
From: Qais Yousef @ 2013-12-09 9:49 UTC (permalink / raw)
To: linux-mips; +Cc: Qais Yousef
The file uses u16 type but doesn't include its definition explicitly
I was getting this error when including this header in my driver:
arch/mips/include/asm/mipsregs.h:644:33: error: unknown type name ‘u16’
Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
changes since v1:
- include linux/types.h instead of s/u16/unsigned short/
- amend commit message accordingly
arch/mips/include/asm/mipsregs.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h
index e033141..86479bb 100644
--- a/arch/mips/include/asm/mipsregs.h
+++ b/arch/mips/include/asm/mipsregs.h
@@ -14,6 +14,7 @@
#define _ASM_MIPSREGS_H
#include <linux/linkage.h>
+#include <linux/types.h>
#include <asm/hazards.h>
#include <asm/war.h>
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h
@ 2013-12-09 9:49 ` Qais Yousef
0 siblings, 0 replies; 6+ messages in thread
From: Qais Yousef @ 2013-12-09 9:49 UTC (permalink / raw)
To: linux-mips; +Cc: Qais Yousef
The file uses u16 type but doesn't include its definition explicitly
I was getting this error when including this header in my driver:
arch/mips/include/asm/mipsregs.h:644:33: error: unknown type name ‘u16’
Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
changes since v1:
- include linux/types.h instead of s/u16/unsigned short/
- amend commit message accordingly
arch/mips/include/asm/mipsregs.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h
index e033141..86479bb 100644
--- a/arch/mips/include/asm/mipsregs.h
+++ b/arch/mips/include/asm/mipsregs.h
@@ -14,6 +14,7 @@
#define _ASM_MIPSREGS_H
#include <linux/linkage.h>
+#include <linux/types.h>
#include <asm/hazards.h>
#include <asm/war.h>
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h
2013-12-09 9:49 ` Qais Yousef
(?)
@ 2013-12-09 18:48 ` David Daney
-1 siblings, 0 replies; 6+ messages in thread
From: David Daney @ 2013-12-09 18:48 UTC (permalink / raw)
To: Qais Yousef; +Cc: linux-mips
On 12/09/2013 01:49 AM, Qais Yousef wrote:
> The file uses u16 type but doesn't include its definition explicitly
>
> I was getting this error when including this header in my driver:
>
> arch/mips/include/asm/mipsregs.h:644:33: error: unknown type name ‘u16’
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
Acked-by: David Daney <david.daney@cavium.com>
> ---
> changes since v1:
> - include linux/types.h instead of s/u16/unsigned short/
> - amend commit message accordingly
>
> arch/mips/include/asm/mipsregs.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h
> index e033141..86479bb 100644
> --- a/arch/mips/include/asm/mipsregs.h
> +++ b/arch/mips/include/asm/mipsregs.h
> @@ -14,6 +14,7 @@
> #define _ASM_MIPSREGS_H
>
> #include <linux/linkage.h>
> +#include <linux/types.h>
> #include <asm/hazards.h>
> #include <asm/war.h>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h
2013-12-09 9:49 ` Qais Yousef
(?)
(?)
@ 2014-03-14 12:08 ` Qais Yousef
2014-03-14 13:20 ` Ralf Baechle
2014-03-20 11:06 ` Luís Henriques
-1 siblings, 2 replies; 6+ messages in thread
From: Qais Yousef @ 2014-03-14 12:08 UTC (permalink / raw)
To: stable@vger.kernel.org
Cc: linux-mips@linux-mips.org, Ralf Baechle (ralf@linux-mips.org)
Can we include this patch in the next 3.10 and forward stable releases please?
It's already in Linus' tree under commit id: 87c99203fea897fbdd84b681ad9fced2517dcf98
Thanks,
Qais
> -----Original Message-----
> From: Qais Yousef
> Sent: 09 December 2013 09:50
> To: linux-mips@linux-mips.org
> Cc: Qais Yousef
> Subject: [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h
>
> The file uses u16 type but doesn't include its definition explicitly
>
> I was getting this error when including this header in my driver:
>
> arch/mips/include/asm/mipsregs.h:644:33: error: unknown type name ‘u16’
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
> ---
> changes since v1:
> - include linux/types.h instead of s/u16/unsigned short/
> - amend commit message accordingly
>
> arch/mips/include/asm/mipsregs.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/include/asm/mipsregs.h
> b/arch/mips/include/asm/mipsregs.h
> index e033141..86479bb 100644
> --- a/arch/mips/include/asm/mipsregs.h
> +++ b/arch/mips/include/asm/mipsregs.h
> @@ -14,6 +14,7 @@
> #define _ASM_MIPSREGS_H
>
> #include <linux/linkage.h>
> +#include <linux/types.h>
> #include <asm/hazards.h>
> #include <asm/war.h>
>
> --
> 1.7.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h
2014-03-14 12:08 ` Qais Yousef
@ 2014-03-14 13:20 ` Ralf Baechle
2014-03-20 11:06 ` Luís Henriques
1 sibling, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2014-03-14 13:20 UTC (permalink / raw)
To: Qais Yousef; +Cc: stable@vger.kernel.org, linux-mips@linux-mips.org
On Fri, Mar 14, 2014 at 12:08:13PM +0000, Qais Yousef wrote:
> Can we include this patch in the next 3.10 and forward stable releases please?
>
> It's already in Linus' tree under commit id: 87c99203fea897fbdd84b681ad9fced2517dcf98
Sure. I've done so for the lmo -stable branches.
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h
2014-03-14 12:08 ` Qais Yousef
2014-03-14 13:20 ` Ralf Baechle
@ 2014-03-20 11:06 ` Luís Henriques
1 sibling, 0 replies; 6+ messages in thread
From: Luís Henriques @ 2014-03-20 11:06 UTC (permalink / raw)
To: Qais Yousef
Cc: stable@vger.kernel.org, linux-mips@linux-mips.org,
Ralf Baechle (ralf@linux-mips.org)
On Fri, Mar 14, 2014 at 12:08:13PM +0000, Qais Yousef wrote:
> Can we include this patch in the next 3.10 and forward stable releases please?
>
> It's already in Linus' tree under commit id: 87c99203fea897fbdd84b681ad9fced2517dcf98
>
> Thanks,
> Qais
Thank you, I'm queuing it for the 3.11 kernel.
Cheers,
--
Luís
> > -----Original Message-----
> > From: Qais Yousef
> > Sent: 09 December 2013 09:50
> > To: linux-mips@linux-mips.org
> > Cc: Qais Yousef
> > Subject: [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h
> >
> > The file uses u16 type but doesn't include its definition explicitly
> >
> > I was getting this error when including this header in my driver:
> >
> > arch/mips/include/asm/mipsregs.h:644:33: error: unknown type name ‘u16’
> >
> > Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> > Reviewed-by: Steven J. Hill <Steven.Hill@imgtec.com>
> > ---
> > changes since v1:
> > - include linux/types.h instead of s/u16/unsigned short/
> > - amend commit message accordingly
> >
> > arch/mips/include/asm/mipsregs.h | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/mips/include/asm/mipsregs.h
> > b/arch/mips/include/asm/mipsregs.h
> > index e033141..86479bb 100644
> > --- a/arch/mips/include/asm/mipsregs.h
> > +++ b/arch/mips/include/asm/mipsregs.h
> > @@ -14,6 +14,7 @@
> > #define _ASM_MIPSREGS_H
> >
> > #include <linux/linkage.h>
> > +#include <linux/types.h>
> > #include <asm/hazards.h>
> > #include <asm/war.h>
> >
> > --
> > 1.7.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-20 11:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-09 9:49 [PATCH v2] mips/include/asm/mipsregs.h: include linux/types.h Qais Yousef
2013-12-09 9:49 ` Qais Yousef
2013-12-09 18:48 ` David Daney
2014-03-14 12:08 ` Qais Yousef
2014-03-14 13:20 ` Ralf Baechle
2014-03-20 11:06 ` Luís Henriques
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.